Add debug info support for function arguments in async functions. #35028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedantk
reviewed
Dec 10, 2020
lib/IRGen/IRGenDebugInfo.cpp
Outdated
| // give CoroSplit.cpp license to emit a shadow copy for them pointing inside | ||
| // the Swift Context argument that is valid throughout the function. | ||
| auto &EntryBlock = BB->getParent()->getEntryBlock(); | ||
| if (auto *InsertBefore = EntryBlock.getFirstNonPHIOrDbg()) |
There was a problem hiding this comment.
Can this be simplified using entryBlock.getFirstInsertionPt() ("Returns an iterator to the first instruction in this block that is suitable for inserting a non-PHI instruction.")?
lib/IRGen/IRGenDebugInfo.h
Outdated
| DirectValue, | ||
| IndirectValue, | ||
| InCoroContext, | ||
| InCoroContextIndirect |
There was a problem hiding this comment.
Total nitpick: wdyt of replacing {'InCoroContext', 'InCoroContextIndirect'} with {'CoroDirectValue' and 'CoroIndirectValue'}? Naming might feel a bit more similar that way. Another option might be an enum class, then you could spell 'IndirectionKind::Direct', 'IndirectionKind::CoroDirect' etc.
adrian-prantl
force-pushed
the
71866936
branch
from
4a5a32b to
2219595
Compare
|
@swift-ci test |
This commit depends on changes to the coroutine-splitting pass in LLVM. Shadow copies are also turned off for async function arguments, because they make it impossible to track debug info during coroutine splitting. Instead we are relying on LLVM's CoroSplit.cpp to emit shadow copies. The Swift frontend gives CoroSplit license to move do this by describing the arguments using a dbg.declare intrinsic, even though it points to chain of load/GEP/bitcase instructions into the Swift context function argument. rdar://71866936
adrian-prantl
force-pushed
the
71866936
branch
from
2219595 to
0e6a0b8
Compare
|
@swift-ci test |
|
Build failed |
|
@swift-ci test |
vedantk
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit depends on changes to the coroutine-splitting pass in LLVM. Shadow
copies are also turned off for async function arguments, because they make it
impossible to track debug info during coroutine splitting. Instead we are
relying on LLVM's CoroSplit.cpp to emit shadow copies. The Swift frontend gives
CoroSplit license to move do this by describing the arguments using a
dbg.declare intrinsic, even though it points to chain of load/GEP/bitcase
instructions into the Swift context function argument.
rdar://71866936