[Timer] Count number of executed instructions on macOS #2350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
instruction-counter-stable
branch
from
286f971 to
4415993
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
instruction-counter-stable
branch
from
4415993 to
cfe48c2
Compare
|
@swift-ci Please test |
In addition to wall time etc. this should allow us to get less noisy values for time measurements.
ahoppen
force-pushed
the
instruction-counter-stable
branch
from
cfe48c2 to
c1bc52c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test linux platform |
|
Linux failure seems unrelated and bot is passing again. Let’s try again. @swift-ci Please test linux platform |
3 tasks
|
@swift-ci Please test linux platform |
|
Merging this into upstream LLVM now: https://reviews.llvm.org/D96049 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to get performance timers for the Swift parser that are as accurate as possible, I found this PR by Graydon (swiftlang/swift#18658) from a couple years ago, adding a performance metric that counts the number of executed instructions on macOS. According to Graydon (and my intuition), this number is a lot less noisy than the time values.
With this PR, I'm trying to taking the measurements a little bit further by recording them with every LLVM
Timer. This way, we get the measurement for free in every place that LLVMTimers are used (which happens to include measurements for the Swift parser, my original goal).The code is mostly copy-based from either Graydon's PR or other places in
Timer.h/cpp. I would appreciate a thorough code review, in particular regarding the implications of my changes toCMakeList.txt.Also: I'm not sure, if
swift/mainis the correct branch to target, please let me know if I should target a different branch.This supersedes #2270 which targeted
apple/main.