Skip to content

[libSyntax] Require RawSyntax to always live inside a SyntaxArena #35648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2021
Merged

[libSyntax] Require RawSyntax to always live inside a SyntaxArena #35648

merged 1 commit into from
Feb 2, 2021

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jan 29, 2021 •
edited
Loading

This way, we will later be able to store additional information about the node inside the same arena with a guarantee that they will always be alive as long as the node is alive.

These additional information will include
a) the token's text (which can be a StringRef into a copy of the source code that lives inside the SyntaxArena)
b) the token's unparsed trivia, which can be decomposed into pieces when needed.

Performance checklist (performed on my local machine)

  • No regression during compilation
  • No regression during code completion
  • No regression during SwiftSyntax parsing

@ahoppen ahoppen requested a review from rintaro January 29, 2021 16:36
@ahoppen ahoppen marked this pull request as draft January 29, 2021 16:36
@ahoppen
Copy link
Member Author

ahoppen commented Jan 29, 2021

@swift-ci Please smoke test

@ahoppen ahoppen mentioned this pull request Jan 29, 2021
Merged
3 tasks
rintaro
rintaro reviewed Jan 29, 2021
View reviewed changes
Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever idea

@ahoppen ahoppen force-pushed the rawsyntax-in-syntaxarena branch from b00d184 to 30b4677 Compare February 1, 2021 09:29
@ahoppen
Copy link
Member Author

ahoppen commented Feb 1, 2021

Good catches @rintaro. I thought I changed those places already but that must have been on another branch.

@ahoppen
Copy link
Member Author

ahoppen commented Feb 1, 2021

Checking if we didn’t regress compilation performance and whether my instruction counter from the linked LLVM PR work.

swiftlang/llvm-project#2350

@swift-ci Please smoke test compiler performance

@ahoppen
[libSyntax] Require RawSyntax to always live inside a SyntaxArena
803499e 
This way, we will later be able to store additional information about
the node inside the same arena with a guarantee that they will always be
alive as long as the node is alive.

These additional information will include
a) the token's text (which can be a StringRef into a copy of the source
   code that lives inside the SyntaxArena)
b) the token's unparsed trivia, which can be decomposed into pieces when
   needed.
@swift-ci
Copy link
Contributor

swift-ci commented Feb 1, 2021

Summary for main smoketest

No regressions above thresholds

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 2,618,497,936,549 2,615,679,913,075 -2,818,023,474 -0.11%
LLVM.NumLLVMBytesOutput 57,678,640 57,679,036 396 0.0%
time.swift-driver.wall 210.5s 212.5s 2.0s 0.94%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (3)
name old new delta delta_pct
Driver.ChildrenMaxRSS 5,902,127,104 5,842,122,752 -60,004,352 -1.02% ✅
Driver.NumDriverPipePolls 480 455 -25 -5.21% ✅
Driver.NumDriverPipeReads 251 225 -26 -10.36% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (256)
name old new delta delta_pct
AST.ImportSetCacheHit 59,058 59,074 16 0.03%
AST.ImportSetCacheMiss 13,032 13,032 0 0.0%
AST.ImportSetFoldHit 4,738 4,738 0 0.0%
AST.ImportSetFoldMiss 8,294 8,294 0 0.0%
AST.ModuleShadowCacheHit 131 131 0 0.0%
AST.ModuleShadowCacheMiss 104 104 0 0.0%
AST.ModuleVisibilityCacheHit 463 463 0 0.0%
AST.ModuleVisibilityCacheMiss 148 148 0 0.0%
AST.NumASTBytesAllocated 1,222,875,105 1,223,729,584 854,479 0.07%
AST.NumASTScopeExpansions 143,128 143,128 0 0.0%
AST.NumASTScopeLookups 156,297 156,297 0 0.0%
AST.NumDecls 4,482 4,482 0 0.0%
AST.NumDependencies 7,286 7,286 0 0.0%
AST.NumIncrementalDependencies 0 0 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 6,888 6,888 0 0.0%
AST.NumLocalTypeDecls 15 15 0 0.0%
AST.NumModuleLookupClassMember 710 710 0 0.0%
AST.NumModuleLookupValue 1,788,782 1,789,033 251 0.01%
AST.NumObjCMethods 179 179 0 0.0%
AST.NumOperators 4 4 0 0.0%
AST.NumPrecedenceGroups 2 2 0 0.0%
AST.NumReferencedDynamicNames 22 22 0 0.0%
AST.NumReferencedMemberNames 323,637 323,637 0 0.0%
AST.NumReferencedTopLevelNames 29,689 29,689 0 0.0%
AST.NumSourceBuffers 10,982 10,982 0 0.0%
AST.NumSourceLines 115,750 115,750 0 0.0%
AST.NumSourceLinesPerSecond 32,776 32,698 -78 -0.24%
AST.NumTotalClangImportedEntities 84,118 84,164 46 0.05%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 718 718 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 35,302,493,128 35,525,727,656 223,234,528 0.63%
Frontend.NumInstructionsExecuted 2,618,497,936,549 2,615,679,913,075 -2,818,023,474 -0.11%
Frontend.NumProcessFailures 0 0 0 0.0%
IRGen.IRGenRequest 699 699 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 8,997 8,997 0 0.0%
IRModule.NumIRAliases 4,760 4,760 0 0.0%
IRModule.NumIRBasicBlocks 208,366 208,366 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 112,149 112,149 0 0.0%
IRModule.NumIRGlobals 122,685 122,685 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 2,338,069 2,338,069 0 0.0%
IRModule.NumIRNamedMetaData 3,495 3,495 0 0.0%
IRModule.NumIRValueSymbols 216,424 216,424 0 0.0%
LLVM.NumLLVMBytesOutput 57,678,640 57,679,036 396 0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 6,572 6,572 0 0.0%
Parse.NumIterableDeclContextParsed 17,308 17,308 0 0.0%
Parse.ParseAbstractFunctionBodyRequest 5,730 5,730 0 0.0%
Parse.ParseMembersRequest 16,315 16,315 0 0.0%
Parse.ParseSourceFileRequest 10,935 10,935 0 0.0%
SILGen.ASTLoweringRequest 717 717 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 66,575 66,575 0 0.0%
SILModule.NumSILGenGlobalVariables 2,450 2,450 0 0.0%
SILModule.NumSILGenVtables 450 450 0 0.0%
SILModule.NumSILGenWitnessTables 4,644 4,644 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 80,979 80,979 0 0.0%
SILModule.NumSILOptGlobalVariables 2,505 2,505 0 0.0%
SILModule.NumSILOptVtables 452 452 0 0.0%
SILModule.NumSILOptWitnessTables 5,793 5,793 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 2,814 2,814 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.ABIMembersRequest 430 430 0 0.0%
Sema.AbstractGenericSignatureRequest 378 378 0 0.0%
Sema.AccessLevelRequest 331,207 332,185 978 0.3%
Sema.ActorIsolationRequest 19,352 19,352 0 0.0%
Sema.AllMembersRequest 4,786 4,786 0 0.0%
Sema.AnyObjectLookupRequest 34 34 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 313 313 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 15,527 15,527 0 0.0%
Sema.AttachedPropertyWrappersRequest 74,394 74,394 0 0.0%
Sema.AttachedResultBuilderRequest 18,024 18,024 0 0.0%
Sema.BodyInitKindRequest 1,256 1,256 0 0.0%
Sema.CallerSideDefaultArgExprRequest 647 647 0 0.0%
Sema.CanBeAsyncHandlerRequest 4,045 4,045 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 211 211 0 0.0%
Sema.CheckRedeclarationRequest 24,326 24,326 0 0.0%
Sema.ClassAncestryFlagsRequest 2,682 2,682 0 0.0%
Sema.ClosureHasExplicitResultRequest 3,264 3,264 0 0.0%
Sema.CodeCompletionFileRequest 0 0 0 0.0%
Sema.CollectOverriddenDeclsRequest 198,503 199,355 852 0.43%
Sema.CompareDeclSpecializationRequest 15,110 15,163 53 0.35%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 0 0 0 0.0%
Sema.CustomAttrTypeRequest 0 0 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 1,605 1,605 0 0.0%
Sema.DefaultArgumentExprRequest 1,105 1,105 0 0.0%
Sema.DefaultArgumentInitContextRequest 13 13 0 0.0%
Sema.DefaultDefinitionTypeRequest 135 135 0 0.0%
Sema.DefaultTypeRequest 6,010 6,010 0 0.0%
Sema.DerivativeAttrOriginalDeclRequest 0 0 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 887,670 887,980 310 0.03%
Sema.DirectOperatorLookupRequest 55,122 55,129 7 0.01%
Sema.DirectPrecedenceGroupLookupRequest 16,783 16,783 0 0.0%
Sema.DynamicallyReplacedDeclRequest 27,355 27,355 0 0.0%
Sema.EnumRawTypeRequest 639 639 0 0.0%
Sema.EnumRawValuesRequest 254 254 0 0.0%
Sema.ExistentialConformsToSelfRequest 458 458 0 0.0%
Sema.ExistentialTypeSupportedRequest 334 334 0 0.0%
Sema.ExtendedNominalRequest 18,837 18,837 0 0.0%
Sema.ExtendedTypeRequest 2,265 2,265 0 0.0%
Sema.FragileFunctionKindRequest 40,138 40,138 0 0.0%
Sema.FunctionOperatorRequest 557 557 0 0.0%
Sema.FunctionRethrowingKindRequest 10,298 10,298 0 0.0%
Sema.GenericParamListRequest 118,312 118,472 160 0.14%
Sema.GenericSignatureRequest 64,421 64,447 26 0.04%
Sema.GetDestructorRequest 386 386 0 0.0%
Sema.GlobalActorAttributeRequest 21,015 21,015 0 0.0%
Sema.GlobalActorInstanceRequest 0 0 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 180 180 0 0.0%
Sema.HasCircularRawValueRequest 222 222 0 0.0%
Sema.HasDefaultInitRequest 1,348 1,348 0 0.0%
Sema.HasDynamicCallableAttributeRequest 0 0 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 17,051 17,060 9 0.05%
Sema.HasImplementationOnlyImportsRequest 10,935 10,935 0 0.0%
Sema.HasMemberwiseInitRequest 860 860 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 406 406 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 1,348 1,348 0 0.0%
Sema.InferredGenericSignatureRequest 2,892 2,892 0 0.0%
Sema.InheritedDeclsReferencedRequest 155,444 155,752 308 0.2%
Sema.InheritedProtocolsRequest 16,310 16,328 18 0.11%
Sema.InheritedTypeRequest 4,808 4,818 10 0.21%
Sema.InheritsSuperclassInitializersRequest 364 364 0 0.0%
Sema.InitKindRequest 2,269 2,269 0 0.0%
Sema.InterfaceTypeRequest 357,693 358,357 664 0.19%
Sema.IsABICompatibleOverrideRequest 3,422 3,422 0 0.0%
Sema.IsAccessorTransparentRequest 7,054 7,054 0 0.0%
Sema.IsActorRequest 7,893 7,896 3 0.04%
Sema.IsAsyncHandlerRequest 39,784 39,808 24 0.06%
Sema.IsCallableNominalTypeRequest 199 199 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDeclRefinementOfRequest 1,151 1,151 0 0.0%
Sema.IsDefaultActorRequest 802 802 0 0.0%
Sema.IsDynamicRequest 43,747 43,747 0 0.0%
Sema.IsFinalRequest 65,256 65,457 201 0.31%
Sema.IsGetterMutatingRequest 11,926 11,926 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 64,196 64,201 5 0.01%
Sema.IsObjCRequest 37,393 37,393 0 0.0%
Sema.IsSetterMutatingRequest 9,217 9,217 0 0.0%
Sema.IsStaticRequest 32,096 32,096 0 0.0%
Sema.LazyStoragePropertyRequest 19 19 0 0.0%
Sema.LookupAllConformancesInContextRequest 3,367 3,367 0 0.0%
Sema.LookupConformanceInModuleRequest 874,664 874,791 127 0.01%
Sema.LookupInModuleRequest 189,268 189,496 228 0.12%
Sema.LookupInfixOperatorRequest 2,152 2,152 0 0.0%
Sema.LookupPostfixOperatorRequest 0 0 0 0.0%
Sema.LookupPrecedenceGroupRequest 674 674 0 0.0%
Sema.LookupPrefixOperatorRequest 4 4 0 0.0%
Sema.MangleLocalTypeDeclRequest 30 30 0 0.0%
Sema.ModuleImplicitImportsRequest 229 229 0 0.0%
Sema.ModuleQualifiedLookupRequest 88,108 88,336 228 0.26%
Sema.NamedLazyMemberLoadSuccessCount 646,695 646,731 36 0.01%
Sema.NamingPatternRequest 6,284 6,284 0 0.0%
Sema.NeedsNewVTableEntryRequest 15,317 15,317 0 0.0%
Sema.NumAccessorBodiesSynthesized 4,588 4,588 0 0.0%
Sema.NumAccessorsSynthesized 6,502 6,502 0 0.0%
Sema.NumConformancesDeserialized 238,595 239,221 626 0.26%
Sema.NumConstraintScopes 578,090 578,189 99 0.02%
Sema.NumConstraintsConsideredForEdgeContraction 1,449,530 1,449,588 58 0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 1,984,748 1,987,251 2,503 0.13%
Sema.NumDeclsTypechecked 36,411 36,411 0 0.0%
Sema.NumGenericSignatureBuilders 28,131 28,242 111 0.39%
Sema.NumLazyIterableDeclContexts 235,579 235,692 113 0.05%
Sema.NumLazyRequirementSignatures 21,283 21,283 0 0.0%
Sema.NumLazyRequirementSignaturesLoaded 15,347 15,349 2 0.01%
Sema.NumLeafScopes 381,961 382,027 66 0.02%
Sema.NumTypesDeserialized 623,249 624,487 1,238 0.2%
Sema.NumUnloadedLazyIterableDeclContexts 144,549 144,515 -34 -0.02%
Sema.OpaqueReadOwnershipRequest 7,139 7,139 0 0.0%
Sema.OpaqueResultTypeRequest 0 0 0 0.0%
Sema.OperatorPrecedenceGroupRequest 8 8 0 0.0%
Sema.OverriddenDeclsRequest 61,174 61,392 218 0.36%
Sema.ParamSpecifierRequest 31,776 31,776 0 0.0%
Sema.PatternBindingEntryRequest 13,362 13,362 0 0.0%
Sema.PatternTypeRequest 16,376 16,376 0 0.0%
Sema.PreCheckResultBuilderRequest 0 0 0 0.0%
Sema.PrimarySourceFilesRequest 229 229 0 0.0%
Sema.PropertyWrapperBackingPropertyInfoRequest 15,313 15,313 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 15,527 15,527 0 0.0%
Sema.PropertyWrapperLValuenessRequest 0 0 0 0.0%
Sema.PropertyWrapperMutabilityRequest 16,773 16,773 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 0 0 0 0.0%
Sema.ProtocolConformanceRefClassifyAsThrowsRequest 0 0 0 0.0%
Sema.ProtocolRequiresClassRequest 898 905 7 0.78%
Sema.ProtocolRethrowsRequirementsRequest 55 55 0 0.0%
Sema.ProvideDefaultImplForRequest 198,503 199,355 852 0.43%
Sema.QualifiedLookupRequest 158,105 158,223 118 0.07%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 3,742 3,742 0 0.0%
Sema.RequirementSignatureRequest 16,450 16,462 12 0.07%
Sema.RequiresOpaqueAccessorsRequest 36,001 36,001 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 5,767 5,767 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 11,872 11,872 0 0.0%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 79,210 79,210 0 0.0%
Sema.ResultBuilderTypeRequest 9,696 9,696 0 0.0%
Sema.ResultTypeRequest 14,106 14,106 0 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 370,158 371,067 909 0.25%
Sema.ScopedImportLookupRequest 0 0 0 0.0%
Sema.SelfAccessKindRequest 15,685 15,685 0 0.0%
Sema.SelfBoundsFromWhereClauseRequest 44,356 44,498 142 0.32%
Sema.SetterAccessLevelRequest 3,440 3,440 0 0.0%
Sema.SimpleDidSetRequest 60,422 60,439 17 0.03%
Sema.SpecializeAttrTargetDeclRequest 80 80 0 0.0%
Sema.StorageImplInfoRequest 41,630 41,630 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 1,650 1,650 0 0.0%
Sema.StoredPropertiesRequest 9,651 9,651 0 0.0%
Sema.StructuralTypeRequest 40 40 0 0.0%
Sema.SuperclassDeclRequest 11,041 11,059 18 0.16%
Sema.SuperclassTypeRequest 924 924 0 0.0%
Sema.SynthesizeAccessorRequest 6,502 6,502 0 0.0%
Sema.SynthesizeDefaultInitRequest 134 134 0 0.0%
Sema.SynthesizeMainFunctionRequest 2,530 2,530 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 139 139 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 12,192 12,192 0 0.0%
Sema.TypeCheckSourceFileRequest 699 699 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 860 860 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 237 237 0 0.0%
Sema.USRGenerationRequest 230,584 231,436 852 0.37%
Sema.UnderlyingTypeDeclsReferencedRequest 5,377 5,397 20 0.37%
Sema.UnderlyingTypeRequest 398 398 0 0.0%
Sema.UnqualifiedLookupRequest 118,121 118,121 0 0.0%
Sema.ValidatePrecedenceGroupRequest 3,848 3,848 0 0.0%
Sema.ValueWitnessRequest 2,143 2,143 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 699 699 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 1,593,067,016,292 1,592,591,498,720 -475,517,572 -0.03%
LLVM.NumLLVMBytesOutput 60,980,716 60,979,552 -1,164 -0.0%
time.swift-driver.wall 259.8s 260.4s 618.6ms 0.24%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (5)
name old new delta delta_pct
AST.NumSourceLinesPerSecond 4,206 4,146 -60 -1.43% ✅
Driver.ChildrenMaxRSS 7,781,935,104 7,688,486,912 -93,448,192 -1.2% ✅
Driver.NumDriverPipePolls 255 241 -14 -5.49% ✅
Driver.NumDriverPipeReads 235 221 -14 -5.96% ✅
Frontend.MaxMallocUsage 6,440,523,520 6,350,113,688 -90,409,832 -1.4% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (254)
name old new delta delta_pct
AST.ImportSetCacheHit 38,407 38,407 0 0.0%
AST.ImportSetCacheMiss 1,599 1,599 0 0.0%
AST.ImportSetFoldHit 879 879 0 0.0%
AST.ImportSetFoldMiss 720 720 0 0.0%
AST.ModuleShadowCacheHit 71 71 0 0.0%
AST.ModuleShadowCacheMiss 56 56 0 0.0%
AST.ModuleVisibilityCacheHit 236 236 0 0.0%
AST.ModuleVisibilityCacheMiss 51 51 0 0.0%
AST.NumASTBytesAllocated 219,194,400 219,192,068 -2,332 -0.0%
AST.NumASTScopeExpansions 75,439 75,439 0 0.0%
AST.NumASTScopeLookups 117,161 117,161 0 0.0%
AST.NumDecls 4,482 4,482 0 0.0%
AST.NumDependencies 620 620 0 0.0%
AST.NumIncrementalDependencies 0 0 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 526 526 0 0.0%
AST.NumLocalTypeDecls 15 15 0 0.0%
AST.NumModuleLookupClassMember 676 676 0 0.0%
AST.NumModuleLookupValue 944,133 944,133 0 0.0%
AST.NumObjCMethods 179 179 0 0.0%
AST.NumOperators 4 4 0 0.0%
AST.NumPrecedenceGroups 2 2 0 0.0%
AST.NumReferencedDynamicNames 0 0 0 0.0%
AST.NumReferencedMemberNames 0 0 0 0.0%
AST.NumReferencedTopLevelNames 0 0 0 0.0%
AST.NumSourceBuffers 706 706 0 0.0%
AST.NumSourceLines 115,750 115,750 0 0.0%
AST.NumTotalClangImportedEntities 15,754 15,754 0 0.0%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 20 20 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.NumInstructionsExecuted 1,593,067,016,292 1,592,591,498,720 -475,517,572 -0.03%
Frontend.NumProcessFailures 0 0 0 0.0%
IRGen.IRGenRequest 0 0 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 6,936 6,936 0 0.0%
IRModule.NumIRAliases 3,691 3,691 0 0.0%
IRModule.NumIRBasicBlocks 176,110 176,110 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 83,735 83,735 0 0.0%
IRModule.NumIRGlobals 102,924 102,924 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 1,513,144 1,513,144 0 0.0%
IRModule.NumIRNamedMetaData 3,495 3,495 0 0.0%
IRModule.NumIRValueSymbols 176,255 176,255 0 0.0%
LLVM.NumLLVMBytesOutput 60,980,716 60,979,552 -1,164 -0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 6,570 6,570 0 0.0%
Parse.NumIterableDeclContextParsed 2,403 2,403 0 0.0%
Parse.ParseAbstractFunctionBodyRequest 5,608 5,608 0 0.0%
Parse.ParseMembersRequest 8 8 0 0.0%
Parse.ParseSourceFileRequest 699 699 0 0.0%
SILGen.ASTLoweringRequest 18 18 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 32,376 32,376 0 0.0%
SILModule.NumSILGenGlobalVariables 2,440 2,440 0 0.0%
SILModule.NumSILGenVtables 250 250 0 0.0%
SILModule.NumSILGenWitnessTables 2,207 2,207 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 27,247 27,247 0 0.0%
SILModule.NumSILOptGlobalVariables 3,157 3,157 0 0.0%
SILModule.NumSILOptVtables 308 308 0 0.0%
SILModule.NumSILOptWitnessTables 2,262 2,262 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 72 72 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.ABIMembersRequest 283 283 0 0.0%
Sema.AbstractGenericSignatureRequest 383 383 0 0.0%
Sema.AccessLevelRequest 38,477 38,477 0 0.0%
Sema.ActorIsolationRequest 12,086 12,086 0 0.0%
Sema.AllMembersRequest 2,393 2,393 0 0.0%
Sema.AnyObjectLookupRequest 34 34 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 212 212 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 10,483 10,483 0 0.0%
Sema.AttachedPropertyWrappersRequest 54,550 54,550 0 0.0%
Sema.AttachedResultBuilderRequest 17,083 17,083 0 0.0%
Sema.BodyInitKindRequest 1,145 1,145 0 0.0%
Sema.CallerSideDefaultArgExprRequest 647 647 0 0.0%
Sema.CanBeAsyncHandlerRequest 3,219 3,219 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 18 18 0 0.0%
Sema.CheckRedeclarationRequest 24,400 24,400 0 0.0%
Sema.ClassAncestryFlagsRequest 1,064 1,064 0 0.0%
Sema.ClosureHasExplicitResultRequest 3,260 3,260 0 0.0%
Sema.CodeCompletionFileRequest 0 0 0 0.0%
Sema.CollectOverriddenDeclsRequest 0 0 0 0.0%
Sema.CompareDeclSpecializationRequest 12,928 12,928 0 0.0%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 0 0 0 0.0%
Sema.CustomAttrTypeRequest 0 0 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 1,101 1,101 0 0.0%
Sema.DefaultArgumentExprRequest 1,105 1,105 0 0.0%
Sema.DefaultArgumentInitContextRequest 0 0 0 0.0%
Sema.DefaultDefinitionTypeRequest 51 51 0 0.0%
Sema.DefaultTypeRequest 5,667 5,667 0 0.0%
Sema.DerivativeAttrOriginalDeclRequest 0 0 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 778,566 778,598 32 0.0%
Sema.DirectOperatorLookupRequest 43,322 43,322 0 0.0%
Sema.DirectPrecedenceGroupLookupRequest 15,915 15,915 0 0.0%
Sema.DynamicallyReplacedDeclRequest 18,837 18,837 0 0.0%
Sema.EnumRawTypeRequest 222 222 0 0.0%
Sema.EnumRawValuesRequest 241 241 0 0.0%
Sema.ExistentialConformsToSelfRequest 119 119 0 0.0%
Sema.ExistentialTypeSupportedRequest 167 167 0 0.0%
Sema.ExtendedNominalRequest 1,218 1,218 0 0.0%
Sema.ExtendedTypeRequest 1,218 1,218 0 0.0%
Sema.FragileFunctionKindRequest 26,164 26,164 0 0.0%
Sema.FunctionOperatorRequest 82 82 0 0.0%
Sema.FunctionRethrowingKindRequest 6,334 6,334 0 0.0%
Sema.GenericParamListRequest 29,812 29,812 0 0.0%
Sema.GenericSignatureRequest 25,380 25,380 0 0.0%
Sema.GetDestructorRequest 293 293 0 0.0%
Sema.GlobalActorAttributeRequest 13,152 13,152 0 0.0%
Sema.GlobalActorInstanceRequest 0 0 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 168 168 0 0.0%
Sema.HasCircularRawValueRequest 222 222 0 0.0%
Sema.HasDefaultInitRequest 794 794 0 0.0%
Sema.HasDynamicCallableAttributeRequest 0 0 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 6,930 6,930 0 0.0%
Sema.HasImplementationOnlyImportsRequest 699 699 0 0.0%
Sema.HasMemberwiseInitRequest 544 544 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 279 279 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 794 794 0 0.0%
Sema.InferredGenericSignatureRequest 1,329 1,329 0 0.0%
Sema.InheritedDeclsReferencedRequest 27,162 27,162 0 0.0%
Sema.InheritedProtocolsRequest 1,959 1,959 0 0.0%
Sema.InheritedTypeRequest 3,406 3,406 0 0.0%
Sema.InheritsSuperclassInitializersRequest 181 181 0 0.0%
Sema.InitKindRequest 1,351 1,351 0 0.0%
Sema.InterfaceTypeRequest 78,334 78,334 0 0.0%
Sema.IsABICompatibleOverrideRequest 3,384 3,384 0 0.0%
Sema.IsAccessorTransparentRequest 6,109 6,109 0 0.0%
Sema.IsActorRequest 1,388 1,388 0 0.0%
Sema.IsAsyncHandlerRequest 16,823 16,823 0 0.0%
Sema.IsCallableNominalTypeRequest 199 199 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDeclRefinementOfRequest 623 623 0 0.0%
Sema.IsDefaultActorRequest 423 423 0 0.0%
Sema.IsDynamicRequest 30,583 30,583 0 0.0%
Sema.IsFinalRequest 24,065 24,065 0 0.0%
Sema.IsGetterMutatingRequest 9,285 9,285 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 49,785 49,785 0 0.0%
Sema.IsObjCRequest 26,470 26,470 0 0.0%
Sema.IsSetterMutatingRequest 8,745 8,745 0 0.0%
Sema.IsStaticRequest 13,906 13,906 0 0.0%
Sema.LazyStoragePropertyRequest 11 11 0 0.0%
Sema.LookupAllConformancesInContextRequest 2,234 2,234 0 0.0%
Sema.LookupConformanceInModuleRequest 965,130 965,331 201 0.02%
Sema.LookupInModuleRequest 61,095 61,095 0 0.0%
Sema.LookupInfixOperatorRequest 1,726 1,726 0 0.0%
Sema.LookupPostfixOperatorRequest 0 0 0 0.0%
Sema.LookupPrecedenceGroupRequest 666 666 0 0.0%
Sema.LookupPrefixOperatorRequest 2 2 0 0.0%
Sema.MangleLocalTypeDeclRequest 15 15 0 0.0%
Sema.ModuleImplicitImportsRequest 18 18 0 0.0%
Sema.ModuleQualifiedLookupRequest 8,658 8,658 0 0.0%
Sema.NamedLazyMemberLoadSuccessCount 230,216 230,216 0 0.0%
Sema.NamingPatternRequest 2,114 2,114 0 0.0%
Sema.NeedsNewVTableEntryRequest 12,701 12,701 0 0.0%
Sema.NumAccessorBodiesSynthesized 4,550 4,550 0 0.0%
Sema.NumAccessorsSynthesized 4,618 4,618 0 0.0%
Sema.NumConformancesDeserialized 71,641 71,641 0 0.0%
Sema.NumConstraintScopes 560,436 560,436 0 0.0%
Sema.NumConstraintsConsideredForEdgeContraction 1,442,133 1,442,133 0 0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 222,218 222,218 0 0.0%
Sema.NumDeclsTypechecked 36,524 36,524 0 0.0%
Sema.NumGenericSignatureBuilders 4,893 4,893 0 0.0%
Sema.NumLazyIterableDeclContexts 26,746 26,746 0 0.0%
Sema.NumLazyRequirementSignatures 1,916 1,916 0 0.0%
Sema.NumLazyRequirementSignaturesLoaded 1,488 1,488 0 0.0%
Sema.NumLeafScopes 367,753 367,753 0 0.0%
Sema.NumTypesDeserialized 110,867 110,867 0 0.0%
Sema.NumUnloadedLazyIterableDeclContexts 16,552 16,552 0 0.0%
Sema.OpaqueReadOwnershipRequest 5,066 5,066 0 0.0%
Sema.OpaqueResultTypeRequest 0 0 0 0.0%
Sema.OperatorPrecedenceGroupRequest 4 4 0 0.0%
Sema.OverriddenDeclsRequest 24,784 24,784 0 0.0%
Sema.ParamSpecifierRequest 19,561 19,561 0 0.0%
Sema.PatternBindingEntryRequest 8,590 8,590 0 0.0%
Sema.PatternTypeRequest 11,602 11,602 0 0.0%
Sema.PreCheckResultBuilderRequest 0 0 0 0.0%
Sema.PrimarySourceFilesRequest 18 18 0 0.0%
Sema.PropertyWrapperBackingPropertyInfoRequest 10,333 10,333 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 10,483 10,483 0 0.0%
Sema.PropertyWrapperLValuenessRequest 0 0 0 0.0%
Sema.PropertyWrapperMutabilityRequest 14,083 14,083 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 0 0 0 0.0%
Sema.ProtocolConformanceRefClassifyAsThrowsRequest 0 0 0 0.0%
Sema.ProtocolRequiresClassRequest 203 203 0 0.0%
Sema.ProtocolRethrowsRequirementsRequest 42 42 0 0.0%
Sema.ProvideDefaultImplForRequest 0 0 0 0.0%
Sema.QualifiedLookupRequest 104,045 104,045 0 0.0%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 2,490 2,490 0 0.0%
Sema.RequirementSignatureRequest 1,742 1,742 0 0.0%
Sema.RequiresOpaqueAccessorsRequest 32,237 32,237 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 4,464 4,464 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 8,684 8,684 0 0.0%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 48,038 48,038 0 0.0%
Sema.ResultBuilderTypeRequest 8,755 8,755 0 0.0%
Sema.ResultTypeRequest 9,473 9,473 0 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 49,042 49,042 0 0.0%
Sema.ScopedImportLookupRequest 0 0 0 0.0%
Sema.SelfAccessKindRequest 8,292 8,292 0 0.0%
Sema.SelfBoundsFromWhereClauseRequest 10,437 10,437 0 0.0%
Sema.SetterAccessLevelRequest 2,905 2,905 0 0.0%
Sema.SimpleDidSetRequest 7,896 7,896 0 0.0%
Sema.SpecializeAttrTargetDeclRequest 39 39 0 0.0%
Sema.StorageImplInfoRequest 35,293 35,293 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 1,075 1,075 0 0.0%
Sema.StoredPropertiesRequest 3,367 3,367 0 0.0%
Sema.StructuralTypeRequest 10 10 0 0.0%
Sema.SuperclassDeclRequest 1,683 1,683 0 0.0%
Sema.SuperclassTypeRequest 434 434 0 0.0%
Sema.SynthesizeAccessorRequest 4,618 4,618 0 0.0%
Sema.SynthesizeDefaultInitRequest 103 103 0 0.0%
Sema.SynthesizeMainFunctionRequest 2,393 2,393 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 90 90 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 12,123 12,123 0 0.0%
Sema.TypeCheckSourceFileRequest 699 699 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 613 613 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 114 114 0 0.0%
Sema.USRGenerationRequest 8,581 8,581 0 0.0%
Sema.UnderlyingTypeDeclsReferencedRequest 1,029 1,029 0 0.0%
Sema.UnderlyingTypeRequest 139 139 0 0.0%
Sema.UnqualifiedLookupRequest 61,585 61,585 0 0.0%
Sema.ValidatePrecedenceGroupRequest 3,838 3,838 0 0.0%
Sema.ValueWitnessRequest 1,192 1,192 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 18 18 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

@ahoppen ahoppen marked this pull request as ready for review February 2, 2021 13:31
@ahoppen ahoppen force-pushed the rawsyntax-in-syntaxarena branch from 30b4677 to 15949dc Compare February 2, 2021 13:32
@ahoppen
Copy link
Member Author

ahoppen commented Feb 2, 2021

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Feb 2, 2021

Build failed
Swift Test OS X Platform
Git Sha - 15949dc9c92e28c6cc83373c2a5ad3af6915703b

@ahoppen ahoppen force-pushed the rawsyntax-in-syntaxarena branch from 15949dc to 803499e Compare February 2, 2021 16:09
@ahoppen
Copy link
Member Author

ahoppen commented Feb 2, 2021

@swift-ci Please test

@ahoppen ahoppen merged commit d5cb754 into swiftlang:main Feb 2, 2021
@ahoppen ahoppen deleted the rawsyntax-in-syntaxarena branch April 5, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rintaro rintaro rintaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahoppen @swift-ci @rintaro