Invert the ownership between SwiftASTContext and TypeSystemSwiftTypeR… #3408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
adrian-prantl
force-pushed
the
invert-ownership
branch
from
9f2a8f6 to
7be7dbc
Compare
|
@swift-ci test |
augusto2112
requested changes
Oct 13, 2021
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
adrian-prantl
force-pushed
the
invert-ownership
branch
from
7be7dbc to
83676ae
Compare
|
@swift-ci test |
…ef (NFC) This patch introduces a new subclass SwiftASTContextForModules, which is now owned by TypeSystemSwiftTypeRef and initialized lazily. The TypeSystemSwiftTypeRef that corresponds to the scratch context is still owned by SwiftASTContextForExpressions. rdar://81717792
adrian-prantl
force-pushed
the
invert-ownership
branch
from
83676ae to
744ae39
Compare
|
@swift-ci test |
kastiglione
reviewed
Oct 14, 2021
Comment on lines
+2853
to
+2856
| module_holder ? module_holder : &ts->GetTypeSystemSwiftTypeRef(), | ||
| module_holder ? module_holder->GetSwiftASTContext() | ||
| : ts->GetSwiftASTContext(), | ||
| dem, mangled_name.GetStringRef()); |
There was a problem hiding this comment.
I remember these ternaries, I wanted to get back to them to remove them. There are two callers of SwiftLanguageRuntimeImpl::GetTypeRef(), and in both cases, they pass in a type, and a TypeSystemSwiftTypeRef derived from that type. Then here, it's derived again.
In other words, the both caller and callee are doing type.GetTypeSystem()->GetTypeSystemSwiftTypeRef() (ignoring the cast for simplicity). I think these ternaries can be removed.
There was a problem hiding this comment.
I will do this in a follow-up commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ef (NFC)
This patch introduces a new subclass SwiftASTContextForModules, which
is now owned by TypeSystemSwiftTypeRef and initialized lazily. The
TypeSystemSwiftTypeRef that corresponds to the scratch context is
still owned by SwiftASTContextForExpressions.
rdar://81717792