[lldb] Remove some trivial scoped timers #3637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While profiling lldb (from swift/llvm-project), these timers were noticed to be short lived and high firing, and so they add noise more than value. The data points I recorded are: `FindTypes_Impl`: 49,646 calls, 812ns avg, 40.33ms total `AppendSymbolIndexesWithName`: 36,229 calls, 913ns avg, 33.09ms total `FindAllSymbolsWithNameAndType`: 36,229 calls, 1.93µs avg, 70.05ms total `FindSymbolsWithNameAndType`: 23,263 calls, 3.09µs avg, 71.88ms total Differential Revision: https://reviews.llvm.org/D115182 (cherry picked from commit 13278ef)
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While profiling lldb (from swift/llvm-project), these timers were noticed to be short lived and high firing, and so they add noise more than value.
The data points I recorded are:
FindTypes_Impl: 49,646 calls, 812ns avg, 40.33ms totalAppendSymbolIndexesWithName: 36,229 calls, 913ns avg, 33.09ms totalFindAllSymbolsWithNameAndType: 36,229 calls, 1.93µs avg, 70.05ms totalFindSymbolsWithNameAndType: 23,263 calls, 3.09µs avg, 71.88ms totalDifferential Revision: https://reviews.llvm.org/D115182
(cherry picked from commit 13278ef)