Skip to content

[lldb] Remove some unnecessary scoped timers in TypeSystemSwiftTypeRef #3743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kastiglione
Copy link

In Instruments traces, these two timers show to be somewhat high firing, while also having quite short durations.

Name Count Duration Min Duration Avg Duration Std Dev Duration Max Duration
GetCanonicalDemangleTree 4,214 224.15 ms 9.24 µs 53.19 µs 61.87 µs 620.08 µs
GetDemangledType 3,849 141.02 ms 8.51 µs 36.64 µs 13.83 µs 142.81 µs

These don't seem to bring any value, and do add noise and overhead to the trace. For that reason, I think they can be deleted. See also #3637.

@kastiglione
Copy link
Author

@swift-ci test

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's good to clean those up.

@kastiglione kastiglione merged commit 9968d29 into stable/20210726 Jan 6, 2022
@kastiglione kastiglione deleted the lldb-Remove-some-unnecessary-scoped-timers-in-TypeSystemSwiftTypeRef branch January 6, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants