Move (most of) No.Swiftmodule into a proper API test. #3895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
commented
Feb 4, 2022
| ifneq "$(CODESIGN)" "" | ||
| $(CODESIGN) -s - "$(EXE)" | ||
| endif | ||
| else # OS = Linux | ||
| $(EXE): $(MODULENAME).swiftmodule.o $(OBJECTS) | ||
| @echo "### Linking" $(EXE) | ||
| ifneq "$(EXCLUDE_WRAPPED_SWIFTMODULE)" "" | ||
| ifneq "$(HIDE_SWIFTMODULE)" "" |
There was a problem hiding this comment.
Turns out this was no longer used by any test...
adrian-prantl
force-pushed
the
reflection-test
branch
from
e2f5261 to
3ee72f1
Compare
|
@swift-ci test |
adrian-prantl
force-pushed
the
reflection-test
branch
from
3ee72f1 to
9ace5e1
Compare
|
@swift-ci test |
kastiglione
approved these changes
Feb 7, 2022
kastiglione
reviewed
Feb 7, 2022
Comment on lines
+29
to
+32
| public enum WithPayload { | ||
| case empty | ||
| case with(i: Int) | ||
| } |
There was a problem hiding this comment.
Just a thought: should we include a multi-payload enum here, commented out, with a link to the radar?
|
@swift-ci test |
|
@swift-ci test |
adrian-prantl
force-pushed
the
reflection-test
branch
from
9ace5e1 to
a4d90b3
Compare
|
@swift-ci test |
Testing debugging from just reflection metadata is very important on all platforms. Shell tests only run on the host. By migrating this test to an API test we can make sure this is also tested when debugging on iOS devices.
adrian-prantl
force-pushed
the
reflection-test
branch
from
a4d90b3 to
dd1c41d
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing debugging from just reflection metadata is very important on
all platforms. Shell tests only run on the host. By migrating this
test to an API test we can make sure this is also tested when
debugging on iOS devices.