Cleanup playgrounds test driver #3923
Conversation
|
I'm seeing mystery errors only in PR testing, I'm hoping that the error assertion will make this more debuggable. |
|
For example: #3895 |
| @@ -100,9 +79,10 @@ def execute_code(self, inputFile): | |||
| contents = contents_file.read() | |||
|
|
|||
| result = self.frame.EvaluateExpression(contents, self.options) | |||
| ouput = self.frame.EvaluateExpression("get_output()") | |||
| output = self.frame.EvaluateExpression("get_output()") | |||
| self.assertEquals(str(output.GetError()), 'success') | |||
There was a problem hiding this comment.
SBError has a Success() method and a .success property. Either of those seems more straightforward than relying on the str value.
There was a problem hiding this comment.
Note, there's also an lldbtest.assertSuccess() method that asserts the success of an SB Error and forwards the error message to the test output if it failed. That's probably even more convenient.
There was a problem hiding this comment.
there's also an
lldbtest.assertSuccess()
TIL!
There was a problem hiding this comment.
The intention was that if it fails, we would see the stringified error in the comparsion failure.
There was a problem hiding this comment.
Due to the extreme latency of the PR testers I might fix that up in a separate PR.
There was a problem hiding this comment.
Done. A random build failrue saved the day!
|
@swift-ci test |
adrian-prantl
force-pushed
the
playgrounds
branch
from
21cbd72 to
62b1d01
Compare
|
@swift-ci test |
@swift-ci test