[lldb] Calculate stride of clang types on emplaceClangTypeInfo. #3914
Conversation
|
@swift-ci test |
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Outdated
Show resolved
Hide resolved
augusto2112
force-pushed
the
calculate-stride
branch
from
9d75f80 to
54158eb
Compare
|
@swift-ci test |
| @@ -664,17 +664,21 @@ SwiftLanguageRuntimeImpl::emplaceClangTypeInfo( | |||
| m_clang_type_info.insert({clang_type.GetOpaqueQualType(), llvm::None}); | |||
| return nullptr; | |||
| } | |||
| auto byte_align = *bit_align / 8; | |||
There was a problem hiding this comment.
is bit_align guaranteed to be a multiple of 8?
There was a problem hiding this comment.
Not sure, I just moved that from a block of code below:
swift::reflection::TypeInfo(swift::reflection::TypeInfoKind::Builtin,
*byte_size, *bit_align / 8, 0, 0, true)});
I'll find out.
There was a problem hiding this comment.
Do you think we have an alignment that's not expressible in bytes though?
There was a problem hiding this comment.
I wouldn't think so. Sounds like this calls for an assert.
|
Unrelated failure: |
|
@swift-ci test macOS |
augusto2112
force-pushed
the
calculate-stride
branch
from
54158eb to
0b9c2a7
Compare
|
@swift-ci test |
| #ifndef bridging_header_h | ||
| #define bridging_header_h |
There was a problem hiding this comment.
do bridging headers need these? Normal objc doesn't need these because #import has this behavior.
| print(array) //%self.expect('frame variable array[0]', substrs=['[0]', '.SampleEnumZero']) | ||
| //%self.expect('frame variable array[1]', substrs=['[1]', '.SampleEnumOne']) | ||
| //%self.expect('frame variable array[2]', substrs=['[2]', '.SampleEnumTwo']) | ||
| //FIXME: frame variable array[3] returns [.SampleEnumOne, .SampleEnumTwo] |
There was a problem hiding this comment.
When you find out why this is happening, I'd love to know what the reason is.
There was a problem hiding this comment.
Do you mean the FIXME? I saw it when I wrote the test, I have no idea why it's happening yet.
There was a problem hiding this comment.
yes the FIXME, I'd like to know what the underlying issue is
|
@swift-ci test macOS |
rdar://83990756