-
Notifications
You must be signed in to change notification settings - Fork 344
[lldb] Calculate stride of clang types on emplaceClangTypeInfo. #3914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
SWIFT_SOURCES := main.swift | ||
SWIFT_BRIDGING_HEADER := bridging-header.h | ||
SWIFT_OBJC_INTEROP := 1 | ||
include Makefile.rules |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import lldbsuite.test.lldbinline as lldbinline | ||
from lldbsuite.test.decorators import * | ||
|
||
lldbinline.MakeInlineTest(__file__, globals(), decorators=[swiftTest, skipUnlessFoundation]) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
#ifndef bridging_header_h | ||
#define bridging_header_h | ||
Comment on lines
+1
to
+2
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do bridging headers need these? Normal objc doesn't need these because |
||
|
||
#import <Foundation/Foundation.h> | ||
|
||
typedef NS_CLOSED_ENUM(NSInteger, SampleEnum) { | ||
SampleEnumZero, | ||
SampleEnumOne, | ||
SampleEnumTwo, | ||
SampleEnumThree, | ||
}; | ||
#endif /* bridging_header_h */ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
let array = [SampleEnum.zero, SampleEnum.one, SampleEnum.two, SampleEnum.three] | ||
print(array) //%self.expect('frame variable array[0]', substrs=['[0]', '.SampleEnumZero']) | ||
//%self.expect('frame variable array[1]', substrs=['[1]', '.SampleEnumOne']) | ||
//%self.expect('frame variable array[2]', substrs=['[2]', '.SampleEnumTwo']) | ||
//FIXME: frame variable array[3] returns [.SampleEnumOne, .SampleEnumTwo] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When you find out why this is happening, I'd love to know what the reason is. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you mean the FIXME? I saw it when I wrote the test, I have no idea why it's happening yet. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes the FIXME, I'd like to know what the underlying issue is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. file a radar for this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
bit_align
guaranteed to be a multiple of 8?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, I just moved that from a block of code below:
I'll find out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we have an alignment that's not expressible in bytes though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't think so. Sounds like this calls for an assert.