[lldb/swift] Add swift type-system progress reporting #4085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test macOS platform |
kastiglione
reviewed
Mar 17, 2022
...PI/functionalities/progress_reporting/swift_progress_reporting/TestSwiftProgressReporting.py
Outdated
Show resolved
Hide resolved
...PI/functionalities/progress_reporting/swift_progress_reporting/TestSwiftProgressReporting.py
Outdated
Show resolved
Hide resolved
...PI/functionalities/progress_reporting/swift_progress_reporting/TestSwiftProgressReporting.py
Outdated
Show resolved
Hide resolved
lldb/test/API/functionalities/progress_reporting/swift_progress_reporting/main.swift
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntime.cpp
Outdated
Show resolved
Hide resolved
medismailben
force-pushed
the
stable/20211026
branch
from
932ae2d to
ccc444a
Compare
|
@swift-ci test |
adrian-prantl
approved these changes
Mar 17, 2022
medismailben
force-pushed
the
stable/20211026
branch
2 times, most recently
from
5cd7e27 to
d1bfff8
Compare
|
@swift-ci test linux platform |
|
@swift-ci test macOS platform |
Signed-off-by: Med Ismail Bennani <[email protected]>
This patch introduces a generic helper class that will listen for event in a background thread and match it against a source broadcaster. If the event received matches the source broadcaster, the event is queued up in a list that the user can access later on. The motivation behind this is to easily test new kinds of events (i.e. Swift type-system progress events). However, this patch also updates `TestProgressReporting.py` and `TestDiagnosticReporting.py` to make use of this new helper class. Differential Revision: https://reviews.llvm.org/D121977 Signed-off-by: Med Ismail Bennani <[email protected]>
This patch reports progress events specific to the swift type-system. Currently, it covers 3 long-running operations: - Setting up the runtime reflection context - Loading implicit modules from the compile unit - Caching them in the expression persistent state It also includes a test a will listen for swift progress events and make sure it we receive them when fetching a swift variable. rdar://75803015 Signed-off-by: Med Ismail Bennani <[email protected]>
This patch simplifies the inferior for TestSwiftProgressReporting, by creating a variable using a type defined in an imported module. It also improve the test by making sure it receives each kind of expected swift progress events. Signed-off-by: Med Ismail Bennani <[email protected]>
medismailben
force-pushed
the
stable/20211026
branch
from
d1bfff8 to
2cb812b
Compare
|
@swift-ci test |
|
There is a race happening only in the test which cause it to fail randomly. I'm working on a fix on llvm.org, will cherry-pick the fix afterwards. Since this only concerns the test, I don't think we should revert all the patches. |
|
This discussion is happening on Phab, should be landing the fix today or tomorrow https://reviews.llvm.org/D122193 |
|
Should be fix with #4109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reports progress events specific to the swift type-system.
Currently, it covers 3 long-running operations:
It also includes a test a will listen for swift progress events and make
sure it we receive them when fetching a swift variable.
rdar://75803015
Signed-off-by: Med Ismail Bennani [email protected]