[lldb/test] Add events listener helper function to lldbtest] #4109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces 2 new lldb utility functions: - lldbutil.start_listening_from: This can be called in the test setup to create a listener and set it up for a specific event mask and add it to the user-provided broadcaster's list. - lldbutil.fetch_next_event: This will use fetch a single event from the provided istener and return it if it matches the provided broadcaster. The motivation behind this is to easily test new kinds of events (i.e. Swift type-system progress events). However, this patch also updates `TestProgressReporting.py` and `TestDiagnosticReporting.py` to make use of these new helper functions. Differential Revision: https://reviews.llvm.org/D122193 Signed-off-by: Med Ismail Bennani <[email protected]>
…per functions This patch updates TestSwiftProgressReporting.py to use the new event listener helper function `start_listening_from` and `fetch_next_event`. It keeps fetching new events until it have matched all the expected swift type-system progress events message. If the we're missing one of the expected event, the test will error out, because of `fetch_next_event` won't be getting any new event. Signed-off-by: Med Ismail Bennani <[email protected]>
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces 2 new lldb utility functions:
lldbutil.start_listening_from: This can be called in the test setup tocreate a listener and set it up for a specific event mask and add it
to the user-provided broadcaster's list.
lldbutil.fetch_next_event: This will use fetch a single event from theprovided istener and return it if it matches the provided broadcaster.
The motivation behind this is to easily test new kinds of events
(i.e. Swift type-system progress events). However, this patch also
updates
TestProgressReporting.pyandTestDiagnosticReporting.pyto make use of these new helper functions.
Differential Revision: https://reviews.llvm.org/D122193
Signed-off-by: Med Ismail Bennani [email protected]