[lldb] Pass requiresRevisionMatch argument to validateSerializedAST #5545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A
|
|
@swift-ci test |
kastiglione
commented
Nov 2, 2022
| @@ -1078,7 +1078,8 @@ static bool DeserializeAllCompilerFlags(swift::CompilerInvocation &invocation, | |||
| swift::serialization::ExtendedValidationInfo extended_validation_info; | |||
| info = swift::serialization::validateSerializedAST( | |||
| buf, invocation.getSILOptions().EnableOSSAModules, | |||
| /*requiredSDK*/StringRef(), &extended_validation_info); | |||
| /*requiredSDK*/ StringRef(), /*requiresRevisionMatch*/ false, | |||
There was a problem hiding this comment.
@adrian-prantl I assume false is what we want here
adrian-prantl
approved these changes
Nov 7, 2022
| @@ -1078,7 +1078,8 @@ static bool DeserializeAllCompilerFlags(swift::CompilerInvocation &invocation, | |||
| swift::serialization::ExtendedValidationInfo extended_validation_info; | |||
| info = swift::serialization::validateSerializedAST( | |||
| buf, invocation.getSILOptions().EnableOSSAModules, | |||
| /*requiredSDK*/StringRef(), &extended_validation_info); | |||
| /*requiredSDK*/ StringRef(), /*requiresRevisionMatch*/ false, | |||
kastiglione
deleted the
dl/lldb-pass-requiresrevisionmatch-argument-to-validateserializedast
branch
adrian-prantl
pushed a commit
that referenced
this pull request
Dec 2, 2022
…5545) Pass `requiresRevisionMatch` argument to `validateSerializedAST` after it was introduced in Swift: swiftlang/swift#61628 (cherry picked from commit 1bfddbc)
adrian-prantl
pushed a commit
to adrian-prantl/llvm-project
that referenced
this pull request
Dec 2, 2022
…wiftlang#5545) Pass `requiresRevisionMatch` argument to `validateSerializedAST` after it was introduced in Swift: swiftlang/swift#61628 (cherry picked from commit 1bfddbc)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
requiresRevisionMatchargument tovalidateSerializedASTafter it was introduced in Swift: swiftlang/swift#61628