Don't require a strict revision match in LLDB #61628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
requested review from
xymus,
bnbarham,
JDevlieghere,
fredriss and
kastiglione
|
@swift-ci test |
|
Note that LLDB implements its own check for the compiler version and it will also warn unless all but the last digit match. |
xymus
approved these changes
Oct 18, 2022
JDevlieghere
approved these changes
Oct 19, 2022
For release-management purposes during development, LLDB's embedded Swift compiler's version number can sometimes be off-by-one in the last digit compared to the Swift compiler. This patch restores the old behavior from before 1718362. rdar://101299168
adrian-prantl
force-pushed
the
101299168
branch
from
cf883af to
3cc2831
Compare
|
@swift-ci test and merge |
|
I forgot to update lldb-moduleimport-test. |
|
@swift-ci test and merge |
1 similar comment
|
@swift-ci test and merge |
kastiglione
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Nov 7, 2022
…5545) Pass `requiresRevisionMatch` argument to `validateSerializedAST` after it was introduced in Swift: swiftlang/swift#61628
adrian-prantl
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Dec 2, 2022
…5545) Pass `requiresRevisionMatch` argument to `validateSerializedAST` after it was introduced in Swift: swiftlang/swift#61628 (cherry picked from commit 1bfddbc)
adrian-prantl
pushed a commit
to adrian-prantl/llvm-project
that referenced
this pull request
Dec 2, 2022
…wiftlang#5545) Pass `requiresRevisionMatch` argument to `validateSerializedAST` after it was introduced in Swift: swiftlang/swift#61628 (cherry picked from commit 1bfddbc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For release-management purposes during development, LLDB's embedded Swift compiler's version number can sometimes be off-by-one in the last digit compared to the Swift compiler.
This patch restores the old behavior from before 1718362.
rdar://101299168