Skip to content

[Gardening] Adjust for apple/swift#29155 #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CodaFi
Copy link

@CodaFi CodaFi commented Jan 14, 2020

Forwarding #563 to master-next.

@CodaFi CodaFi requested a review from adrian-prantl January 14, 2020 19:22
@CodaFi
Copy link
Author

CodaFi commented Jan 14, 2020

@swift-ci test

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@adrian-prantl
Copy link

You may or may not also need to make this change in swift/master-rebranch.

@CodaFi
Copy link
Author

CodaFi commented Jan 15, 2020

@swift-ci test

@CodaFi
Copy link
Author

CodaFi commented Jan 21, 2020

Spoke with Jonas about the branching strategy here. Going to merge this despite the failure for now.

@CodaFi
Copy link
Author

CodaFi commented Jan 21, 2020

⛵️

@CodaFi CodaFi merged commit 9c81881 into swiftlang:swift/master-next Jan 21, 2020
@CodaFi CodaFi deleted the istanbul-was-const-antinople branch January 21, 2020 22:04
@CodaFi
Copy link
Author

CodaFi commented Jan 21, 2020

Off to swift/master-rebranch next

@CodaFi
Copy link
Author

CodaFi commented Jan 21, 2020

Ah, cool it's already there. Thanks y'all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants