[Gardening] Sprinkle Const Qualification Around the Frontend #29155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Build failed |
CodaFi
force-pushed
the
west-const-story
branch
from
cfc4426 to
203da7d
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
davidungar
suggested changes
Jan 13, 2020
CodaFi
force-pushed
the
west-const-story
branch
from
203da7d to
44a61be
Compare
CodaFi
force-pushed
the
west-const-story
branch
from
44a61be to
e3f07a0
Compare
|
@swift-ci smoke test |
davidungar
reviewed
Jan 13, 2020
lib/Frontend/CompilerInvocation.cpp
Outdated
| @@ -111,6 +111,59 @@ static void updateRuntimeLibraryPaths(SearchPathOptions &SearchPathOpts, | |||
| } | |||
| } | |||
|
|
|||
| // FIXME: This function is a bit of a layering violation. It should be | |||
| // dispersed into IRGen option parsing if possible. | |||
There was a problem hiding this comment.
It would be nice to explain specifically how it violates layering--would help a noobie. Also since it is required to preserve the incoming settings, where do they come from?
davidungar
approved these changes
Jan 13, 2020
CodaFi
added a commit
to CodaFi/llvm-project
that referenced
this pull request
Jan 14, 2020
|
@swift-ci smoke test macOS platform |
|
@swift-ci clean smoke test macOS platform |
Use the presence or absence of the PGO reader instead. SILGen was wiping out this option then checking for it being wiped out anyways.
This was being done at an odd point in the frontend presumably because by that point the private discriminator had been fully computed. Instead, push the conditions for generating the prefix data down to debug info generation and stop mutating IRGenOptions::DebugFlag in the frontend.
Add an extra phase after all the argument parsing has completed that sets inter-option-dependent flags. This allows for the const-qualification of IRGenOptions, and removes some weird state flipping in FrontendTool.
The REPL was using the CompilerInstance to stash this parameter, then it would immediately move it into IRGen. Drop the setter and pass this data directly.
CodaFi
force-pushed
the
west-const-story
branch
from
e3f07a0 to
e1b6e2b
Compare
|
@swift-ci smoke test |
For those operations that do not need to emit diagnostics or manipulate modules, there's no reason to mutate the passed instance.
CodaFi
force-pushed
the
west-const-story
branch
from
e1b6e2b to
2af598f
Compare
|
@swift-ci smoke test |
|
@swift-ci clean smoke test macOS platform |
|
Ugh, finally. |
|
⛵️ |
CodaFi
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Jan 14, 2020
[Gardening] Adjust for swiftlang/swift#29155
CodaFi
added a commit
to CodaFi/llvm-project
that referenced
this pull request
Jan 14, 2020
JDevlieghere
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Jan 16, 2020
(cherry picked from commit 5d455c2)
CodaFi
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Jan 21, 2020
[Gardening] Adjust for swiftlang/swift#29155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Const-qualify a bunch of frontend-related data structures like the compiler instance, compiler invocation, and frontend options wherever as much as possible. This entailed pushing state callers would previously mutate down as parameters.
Goes a long way towards rdar://57122646