Deserialize Swift macro implementation paths from Swift modules #6753
Conversation
adrian-prantl
requested review from
kastiglione,
rintaro,
xymus and
augusto2112
| }; | ||
|
|
||
| // Discover, rewrite, and unique compiler plugin paths. | ||
| for (auto path : extended_validation_info.getPluginSearchPaths()) { |
There was a problem hiding this comment.
Are we worried about reading invalid local paths in distributed swiftmodules? LLDB could read paths to local macros from a different machine/configuration, it could make LLDB load undesired macro plugins on different machines. Similar to the issue we have with the search paths pointing to /Applications/Xcode.app/.
If so, LLDB could apply those paths only for local non-distributed module using the isNonUserModule check, if a module is non-user it's likely from the SDK, so we could ignore those paths. Alternatively, if we expect macros to be in the SDK we could filter out search paths for distributed modules that point outside the SDK.
There was a problem hiding this comment.
Is isNonUserModule encoded in the validation info somewhere? I couldn't find it on first glance.
There was a problem hiding this comment.
It is available on ModuleDecl and ModuleEntity only at this time, but it only checks the path of the module file iirc so it should be possible to bring it down in the module loading logic as needed.
There was a problem hiding this comment.
We no longer have the original path to the .swiftmodule file when debugging from a .dSYM where all .swiftmodule files have been concatenated into the __swift_ast section of the symbol-rich binary.
This patch parses the Swift compiler plugin paths from all Swift modules and rewrites them to use swift-plugin-server where approprate and adds them to the Swift compiler invocation. rdar://107030837
|
@swift-ci test |
This patch parses the Swift compiler plugin paths from all Swift modules and rewrites them to use swift-plugin-server where approprate and adds them to the Swift compiler invocation.
rdar://107030837
See also swiftlang/swift#65370