Skip to content

[Macros] Serialize plugin search paths for LLDB use #65370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2023
Merged

[Macros] Serialize plugin search paths for LLDB use #65370

merged 1 commit into from
May 2, 2023
+159 −0

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Apr 21, 2023

rdar://107030743

@xymus xymus requested a review from adrian-prantl as a code owner April 21, 2023 22:15
@xymus xymus marked this pull request as draft April 21, 2023 22:15
@adrian-prantl adrian-prantl mentioned this pull request Apr 29, 2023
Merged
@xymus xymus force-pushed the serial-macro-paths branch from 1b97afd to 4f0a757 Compare May 1, 2023 16:57
@xymus xymus force-pushed the serial-macro-paths branch from 4f0a757 to 3ef6087 Compare May 1, 2023 21:07
@xymus
Copy link
Contributor Author

xymus commented May 1, 2023

@swift-ci Please smoke test

@xymus xymus marked this pull request as ready for review May 1, 2023 21:48
@xymus xymus requested a review from rintaro May 1, 2023 21:51
@xymus
Copy link
Contributor Author

xymus commented May 1, 2023

The current implementation always writes the paths in the swiftmodule, it ignores SerializeOptionsForDebugging. I assume the only case where we'd want to ignore some of these search paths is when the swiftmodules are distributed. This may be more a check to apply on the reader side, in LLDB.

rintaro
rintaro approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as long as we're OK to serialize them unconditionally.
I agree that distributing swiftmodule is not common.

@xymus xymus merged commit 421042e into swiftlang:main May 2, 2023
@xymus xymus mentioned this pull request May 3, 2023
Merged
@xymus xymus deleted the serial-macro-paths branch May 3, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rintaro rintaro rintaro approved these changes

@adrian-prantl adrian-prantl Awaiting requested review from adrian-prantl adrian-prantl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xymus @rintaro