Skip to content

[5.9][Macros] Serialize plugin search paths for LLDB use #65616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2023

Conversation

xymus
Copy link
Contributor

@xymus xymus commented May 3, 2023

Write down the plugin search paths in the binary swiftmodule files so LLDB can load them and understand the macros in the expression evaluator. This may list local search paths as expected for debugging locally built modules, however LLDB may want to ignore these paths when read from a distributed swiftmodule file.

Risk: Low, the information will only be read by LLDB. There's no need to bump the swiftmodule format version.
Scope: Macro support in LLDB.
Reviewer: @rintaro

rdar://107030743

Cherry-pick of #65370.

@xymus xymus added the swift 5.9 label May 3, 2023
@xymus xymus requested review from rintaro and adrian-prantl May 3, 2023 15:54
@xymus xymus requested a review from a team as a code owner May 3, 2023 15:54
@xymus
Copy link
Contributor Author

xymus commented May 3, 2023

@swift-ci Please test

@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
@adrian-prantl adrian-prantl merged commit e97bcc6 into swiftlang:release/5.9 May 3, 2023
@xymus xymus deleted the serial-macro-paths-5.9 branch May 3, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants