🌲[lit][clang] Avoid realpath on Windows due to MAX_PATH limitations #7298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running lit tests on Windows can fail because its use of `os.path.realpath` expands substitute drives, which are used to keep paths short and avoid hitting MAX_PATH limitations. Changes lit logic to: Use `os.path.abspath` on Windows, where `MAX_PATH` is a concern that we can work around using substitute drives, which `os.path.realpath` would resolve. Use `os.path.realpath` on Unix, where the current directory always has symlinks resolved, so it is impossible to preserve symlinks in the presence of relative paths, and so we must make sure that all code paths use real paths. Also updates clang's `FileManager::getCanonicalName` and `ExtractAPI` code to avoid resolving substitute drives (i.e. resolving to a path under a different root). How tested: built with `-DLLVM_ENABLE_PROJECTS=clang` and built `check-all` on both Windows Differential Revision: https://reviews.llvm.org/D154130 Reviewed By: @benlangmuir Patch by Tristan Labelle <[email protected]>!
|
@swift-ci please test |
compnerd
approved these changes
Aug 22, 2023
|
Linux failure: This is coming from building early swift syntax on Linux, which isn't quite working yet. |
|
macOS has made it to testing. Merging to get signal on rebranch again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running lit tests on Windows can fail because its use of
os.path.realpathexpands substitute drives, which are used to keep paths short and avoid hitting MAX_PATH limitations.Changes lit logic to:
Use
os.path.abspathon Windows, whereMAX_PATHis a concern that we can work around using substitute drives, whichos.path.realpathwould resolve.Use
os.path.realpathon Unix, where the current directory always has symlinks resolved, so it is impossible to preserve symlinks in the presence of relative paths, and so we must make sure that all code paths use real paths.Also updates clang's
FileManager::getCanonicalNameandExtractAPIcode to avoid resolving substitute drives (i.e. resolving to a path under a different root).How tested: built with
-DLLVM_ENABLE_PROJECTS=clangand builtcheck-allon both WindowsDifferential Revision: https://reviews.llvm.org/D154130
Reviewed By: @benlangmuir
Patch by Tristan Labelle [email protected]!
CC @tristanlabelle
Fixes
AttributeError: module 'lit.util' has no attribute 'abs_path_preserve_drive'failure on Rebranch CI.