Handle scudo rename and changes for rebranch #68063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test Linux |
|
Manually testing the error reporting with |
|
Linux failure Should be fixed by swiftlang/llvm-project#7298 |
|
@swift-ci please smoke test Linux |
|
Scudo is now failing silently. I'll have to take a closer look tomorrow on my linux box. |
|
Issue was that |
|
@swift-ci please smoke test Linux |
The scudo runtime was renamed to indicate that it now must run standalone from other sanitizers. This patch updates the driver to search for the appropriate filename. LLVM rename: https://reviews.llvm.org/D138157
Scudo is now a standalone sanitizer that must be used in isolation. Fixing the driver logic to identify and diagnose when it is used with any other sanitizer.
Scudo crashes when it trips. Pass the `--crash` flag to `not` to handle it properly.
etcwilde
force-pushed
the
ewilde/scudo-rename
branch
from
06c3c98 to
bf4dadc
Compare
|
@swift-ci please smoke test Linux |
|
Driver flag testing wasn't accounting for the fact that scudo has to be run alone now. Fixed that test. |
|
Okay, scudo tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set updates the old driver to handle changes to the scudo sanitizer in upstream LLVM.
The sanitizer is now standalone and shouldn't be used with other sanitizers. In this change, the library was renamed to
scudo_standaloneto reflect the change. As such, the driver maps thescudosanitizer to the appropriate filename.I've also included the updated logic in the driver to ensure that scudo is the only sanitizer passed to the driver, and to otherwise emit a diagnostic.
CC @Lukasa
rdar://114209408