[lldb] Add support for structs and tuple info lookup from DWARF #7775
Conversation
augusto2112
force-pushed
the
full-dwarf-struct
branch
from
53393ed to
f9df834
Compare
|
@swift-ci test |
1 similar comment
| # Check if we should compile in Swift embedded mode | ||
| #---------------------------------------------------------------------- | ||
| ifeq "$(SWIFT_EMBEDDED_MODE)" "1" | ||
| SWIFTFLAGS += -gdwarf-types -enable-experimental-feature Embedded -Xfrontend -disable-objc-interop |
There was a problem hiding this comment.
Should -enable-experimental-feature Embedded imply -gdwarf-types?
There was a problem hiding this comment.
I guess it shouldn't turn on debug info if it's off
There was a problem hiding this comment.
What I'm trying to say is: The swift-driver should turn -g -enable-experimental-feature Embedded into -gdwarf-types -enable-experimental-feature Embedded. Feel free to make this a separate commit
|
@swift-ci test Windows |
augusto2112
force-pushed
the
full-dwarf-struct
branch
from
6429816 to
5d5f4e6
Compare
|
@swift-ci test |
lldb/source/Plugins/LanguageRuntime/Swift/ReflectionContext.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserSwiftDescriptorFinder.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserSwiftDescriptorFinder.cpp
Outdated
Show resolved
Hide resolved
|
|
||
| // TODO: this seems simple to calculate but maybe we should encode the stride | ||
| // in DWARF? That's what reflection metadata does. | ||
| unsigned stride = ((byte_size + alignment - 1) & ~(alignment - 1)); |
There was a problem hiding this comment.
Should this use llvm::alignTo for better readability? https://llvm.org/doxygen/namespacellvm.html#a0654c8f28b6096222fdc77c843576ad6
There was a problem hiding this comment.
I actually tried using that before, but it isn't the same operation as llvm::alignTo (or any other function in math extras that I could find).
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
|
@swift-ci test macOS |
augusto2112
force-pushed
the
full-dwarf-struct
branch
from
5d5f4e6 to
320510e
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
To support embedded Swift, lldb will need to support reading type information from DWARF instead of reflection metadata (whivh it corrently relies on). This patch implements the DescriptorFinder interface by DWARFASTParserSwift, which allows it to provide the data necessary for type info reconstruction without relying on reflection metadata.
augusto2112
force-pushed
the
full-dwarf-struct
branch
from
320510e to
a5ee83c
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
To support embedded Swift, lldb will need to support reading type information from DWARF instead of reflection metadata (whivh it corrently relies on). This patch implements the DescriptorFinder interface by DWARFASTParserSwift, which allows it to provide the data necessary for type info reconstruction without relying on reflection metadata.