Add interface for lookup of externally stored field descriptors #69752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
| @@ -39,13 +41,69 @@ struct BuiltinTypeDescriptorBase { | |||
| virtual llvm::StringRef getMangledTypeName() = 0; | |||
| }; | |||
|
|
|||
| /// An abstract interface for a field record. | |||
There was a problem hiding this comment.
What is a FieldRecord versus a FieldDescriptor?
There was a problem hiding this comment.
A field descriptor describes a nominal type, it has an array of field records, which describes that type's fields.
| /// Load unsubstituted field types for a nominal type. | ||
| RemoteRef<FieldDescriptor> getFieldTypeInfo(const TypeRef *TR); | ||
| std::unique_ptr<FieldDescriptorBase> | ||
| getFieldDescriptor(const TypeRef *TR) override; |
There was a problem hiding this comment.
where did the comment go?
There was a problem hiding this comment.
I moved the whole function, including comment, to a private section.
This is a follow up patch that wraps field descriptors and field records in an abstract interface, and allows descriptor finders to look them up.
augusto2112
force-pushed
the
field-descriptor-interface
branch
from
95ec562 to
e05e3ae
Compare
|
@swift-ci smoke test |
adrian-prantl
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up patch that wraps field descriptors and field records in an abstract interface, and allows descriptor finders to look them up.