Static analyzer cherrypicks 2023/12 #7893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c analysis warnings. The new attribute can be placed on statements in order to suppress arbitrary warnings produced by static analysis tools at those statements. Previously such suppressions were implemented as either informal comments (eg. clang-tidy `// NOLINT:`) or with preprocessor macros (eg. clang static analyzer's `#ifdef __clang_analyzer__`). The attribute provides a universal, formal, flexible and neat-looking suppression mechanism. Implement support for the new attribute in the clang static analyzer; clang-tidy coming soon. The attribute allows specifying which specific warnings to suppress, in the form of free-form strings that are intended to be specific to the tools, but currently none are actually supported; so this is also going to be a future improvement. Differential Revision: https://reviews.llvm.org/D93110 (cherry picked from commit ef3f476) Conflicts: clang/test/SemaCXX/suppress.cpp
…fined on different classes. (llvm#69985) (cherry picked from commit 09273d4)
…ion. It can take raw pointers without triggering a warning. Also retire the support for makeRef and makeWeakPtr as they have been removed from WebKit. (cherry picked from commit 5070c1e)
|
@swift-ci please test |
drodriguez
reviewed
Dec 17, 2023
| [[gsl::suppress]] int x; // expected-error {{'suppress' attribute takes at least 1 argument}} | ||
| [[gsl::suppress()]] int y; // expected-error {{'suppress' attribute takes at least 1 argument}} | ||
| int [[gsl::suppress("r")]] z; // expected-error {{'suppress' attribute cannot be applied to types}} | ||
| [[gsl::suppress(f_)]] float f; // expected-error {{expected string literal as argument of 'suppress' attribute}} |
There was a problem hiding this comment.
This seems to be incorrect for stable/20230725 because the wording only seem implemented in https://reviews.llvm.org/D156237, which was only merged in August 15th.
The generated message in this branch is ”'suppress' attribute requires a string”.
All three instances of ”expected string literal…” in this change should be changed to the former spelling.
There was a problem hiding this comment.
Looks like I forgot to run tests entirely. Sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick [[clang::suppress]] and a couple patches for WebKit checkers.