[lldb] Use canonical QualTypes to determine SwiftOptionSet formatter eligibility #7975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci test Windows |
adrian-prantl
approved these changes
Jan 16, 2024
…eligibility When we lookup a clang type from DWARF by name, we use the first one we find. In this test we have two entities with the name `ComparisonResult`, en enum and a typedef to the enum. So if we happened to find the typedef first, we would fail to apply the `OptionSet` formatter to it because it explicitly wants a QualType whose type-class is an enum. This fixes `lang/swift/enum_objc/TestEnumObjC.py` when applying using the new `FindTypes` `TypeQuery` APIs (see swiftlang#7885) The fix simply gets the canonical type before we check its type-class.
|
@swift-ci test |
|
@swift-ci test Windows |
Michael137
force-pushed
the
bugfix/lldb-optionset-desugar-to-next
branch
from
f7364b5 to
2e77345
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we lookup a clang type from DWARF by name, we use the first one we find. In this test we have two entities with the name
ComparisonResult, en enum and a typedef to the enum. So if we happened to find the typedef first, we would fail to apply theOptionSetformatter to it because it explicitly wants a QualType whose type-class is an enum.This fixes
lang/swift/enum_objc/TestEnumObjC.pywhen using the newFindTypesTypeQueryAPIs (see#7885)
The fix simply gets the canonical type before we check its type-class.