Pass UseCASBackend flag to replayCachedResult. #8002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rastogishubham
requested review from
benlangmuir and
akyrtzi
and removed request for
benlangmuir
|
@swift-ci please test llvm |
rastogishubham
force-pushed
the
UseCASBackend
branch
from
46e6825 to
f058c17
Compare
|
@swift-ci please test llvm |
rastogishubham
force-pushed
the
UseCASBackend
branch
from
f058c17 to
5fe2246
Compare
|
@swift-ci please test llvm |
|
Is there anyway to write a test for it? |
akyrtzi
requested changes
Jan 19, 2024
rastogishubham
force-pushed
the
UseCASBackend
branch
from
5fe2246 to
9959bc1
Compare
|
@swift-ci please test llvm |
rastogishubham
force-pushed
the
UseCASBackend
branch
from
9959bc1 to
658dc4c
Compare
|
@swift-ci please test llvm |
akyrtzi
reviewed
Jan 22, 2024
When using MCCAS, the replay on a cache hit needs to materialize the object file by calling into MCCAS's serializeObjectFile function. Pass the UseCASBackend flag from the CodeGenOpts to replayCachedResult to make sure it knows when to invoke MCCAS serialization.
rastogishubham
force-pushed
the
UseCASBackend
branch
from
658dc4c to
46e6825
Compare
|
@swift-ci please test |
rastogishubham
force-pushed
the
UseCASBackend
branch
from
46e6825 to
5eceb53
Compare
|
@swift-ci please test |
rastogishubham
force-pushed
the
UseCASBackend
branch
from
5eceb53 to
1fe3f3a
Compare
|
@swift-ci please test |
cachemeifyoucan
approved these changes
Jan 22, 2024
rastogishubham
added a commit
that referenced
this pull request
Jan 25, 2024
Pass UseCASBackend flag to replayCachedResult (cherry-pick #8002 to stable/20230725 branch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using MCCAS, the replay on a cache hit needs to materialize the object file by calling into MCCAS's serializeObjectFile function. Pass the UseCASBackend flag from the CodeGenOpts to replayCachedResult to make sure it knows when to invoke MCCAS serialization.