[20230725][CMake] Detect properly new linker introduced in Xcode 15 #8006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained in [1], this linker is functionally equivalent to the classic one (`ld64`) for build system purposes -- in particular to enable the use of order files to link `clang`. For this reason, in addition to fixing the detection rename `LLVM_LINKER_IS_LD64` to `LLVM_LINKER_IS_APPLE` to make the result of such detection more clear -- this should not cause any issue to downstream users, from a quick search in SourceGraph [2], only Swift uses the value of this variable (which I will take care of updating in due time). [1]: https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking [2]: https://sourcegraph.com/search?q=context:global+LLVM_LINKER_IS_LD64+lang:cmake+fork:no+-file:AddLLVM.cmake+-file:clang/tools/driver/CMakeLists.txt&patternType=standard&sm=1&groupBy=repo rdar://120740222 (cherry picked from commit 9175dd9)
|
@swift-ci please test |
|
@swift-ci test llvm |
ldionne
approved these changes
Jan 22, 2024
|
LLVM macOS job has one test failures that matches the ones in #7919 (a previous PR for The linux one has 220 failures, which I don't see in #7919 -- not positive this depends on this changes (since I had no regression when testing on LLVM buildkite), errors seem all related to finding modules |
|
@swift-ci test llvm Linux |
|
In the second Linux run I have the exact failures as #7919 So likely I hit some transient failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in 1, this linker is functionally equivalent to the classic one (
ld64) for build system purposes -- in particular to enable the use of order files to linkclang. For this reason, in addition to fixing the detection renameLLVM_LINKER_IS_LD64toLLVM_LINKER_IS_APPLEto make the result of such detection more clear -- this should not cause any issue to downstream users, from a quick search in SourceGraph 2, only Swift uses the value of this variable (which I will take care of updating in due time).rdar://120740222
(cherry picked from commit 9175dd9)