Skip to content

[lldb] [test] Disable TestTypealiasExpressionParser.py for all platforms #8012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

hamishknight
Copy link

@hamishknight
Copy link
Author

@swift-ci please test

@@ -2,4 +2,4 @@
from lldbsuite.test.decorators import *

# FIXME! The Swift driver insists on passing -experimental-skip-non-inlinable-function-bodies-without-types to -emit-module.
lldbinline.MakeInlineTest(__file__, globals(), decorators=[swiftTest, expectedFailureDarwin(bugnumber="rdar://120928396")])
lldbinline.MakeInlineTest(__file__, globals(), decorators=[swiftTest, skipIf(bugnumber="rdar://120928396")])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lldbinline.MakeInlineTest(__file__, globals(), decorators=[swiftTest, skipIf(bugnumber="rdar://120928396")])
lldbinline.MakeInlineTest(__file__, globals(), decorators=[swiftTest, expectedFailureAll(bugnumber="rdar://120928396")])

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was how I originally had it, but then it UPASSed on Ubuntu 20.04 https://ci.swift.org/job/pr-apple-llvm-project-linux/4333/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, and that is probably how this got in in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants