[AST] Remove SerializedLocalDeclContext #70983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not clear that its worth keeping this as a base class for SerializedAbstractClosure and SerializedTopLevelCodeDecl, most clients are interested in the concrete kinds, not only whether the context is serialized.
hamishknight
requested review from
ahoppen,
bnbarham,
rintaro,
QuietMisdreavus,
hborla,
xedin,
tshortli,
adrian-prantl and
slavapestov
as code owners
|
@swift-ci please test |
hamishknight
commented
Jan 18, 2024
Comment on lines
+113
to
+118
| case DeclContextKind::SerializedTopLevelCodeDecl: | ||
| // Variables declared in a top-level 'guard' statement can be accessed in | ||
| // later top-level code. | ||
| return AccessLevel::FilePrivate; | ||
| case DeclContextKind::AbstractClosureExpr: | ||
| case DeclContextKind::SerializedAbstractClosure: |
There was a problem hiding this comment.
Note I've changed these to match the non-serialized cases, not that it really matters since we'll deserialize the access level anyway
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not clear that its worth keeping this as a base class for SerializedAbstractClosure and SerializedTopLevelCodeDecl, most clients are interested in the concrete kinds, not only whether the context is serialized.