Migrate remaining llvm::Optional to std::optional #8120
Merged
+312
−317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
force-pushed
the
std-optional-all-the-things
branch
2 times, most recently
from
4ace404 to
a2795c9
Compare
|
Nice, did you create the LLDB patch by taking the state of the |
|
On closer inspection, the patch is so straightforward it could be done by a sed script, so we're probably fine in regards to conflicts. |
|
It was just with |
bnbarham
force-pushed
the
std-optional-all-the-things
branch
3 times, most recently
from
70a39e4 to
9746805
Compare
|
@swift-ci please test |
adrian-prantl
approved these changes
Feb 13, 2024
|
|
|
@swift-ci please test |
This has mostly been done, there's just a few left overs (namely LLDB). Leave removing `Optional.h` and `None.h` so that this can be merged irrespective of the Swift changes.
bnbarham
force-pushed
the
std-optional-all-the-things
branch
from
9746805 to
d05e79d
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has mostly been done, there's just a few left overs (namely LLDB). Leave removing
Optional.handNone.hso that this can be merged irrespective of the Swift changes.