[next] Migrate remaining llvm::Optional to std::optional #8179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
changed the title
This has mostly been done, there's just a few left overs (namely LLDB). Leave removing `Optional.h` and `None.h` so that this can be merged irrespective of the Swift changes. (cherry picked from commit d05e79d)
bnbarham
force-pushed
the
next-std-optional-all-the-things
branch
from
220d106 to
e90df00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has mostly been done, there's just a few left overs (namely LLDB). Leave removing
Optional.handNone.hso that this can be merged irrespective of the Swift changes.(cherry picked from commit 97468059920f06c9966f0b0890302e26479e53eb)