[lldb] Update swift::ASTContext API #8165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update lldb to use updated swift::ASTContext API.
|
Please test with following pull request: @swift-ci please test |
1 similar comment
|
Please test with following pull request: @swift-ci please test |
|
Please test with following pull request: @swift-ci please test windows platform |
adrian-prantl
approved these changes
Feb 13, 2024
| @@ -3104,6 +3104,10 @@ swift::symbolgraphgen::SymbolGraphOptions &SwiftASTContext::GetSymbolGraphOption | |||
| return GetCompilerInvocation().getSymbolGraphOptions(); | |||
| } | |||
|
|
|||
| swift::CASOptions &SwiftASTContext::GetCASOptions() { | |||
| return GetCompilerInvocation().getCASOptions(); | |||
There was a problem hiding this comment.
Do the CAS options get serialized in the Swift module together with the rest of the invocation?
There was a problem hiding this comment.
I actually have a follow up patch to include that in the context hash. Does debugger need something from CASOption to be serialized into module?
cachemeifyoucan
deleted the
eng/PR-lldb-update-astcontext-swift-71497
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update lldb to use updated swift::ASTContext API.