Skip to content

[Caching] Use subInvocation to verify interface #71497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2024
Merged

[Caching] Use subInvocation to verify interface #71497

merged 2 commits into from
Feb 13, 2024

Conversation

cachemeifyoucan
Copy link
Contributor

The interface verification needs to read some command-line from the interface file so it needs to be built inside sub-invocation.

rdar://122423965

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#8165

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan mentioned this pull request Feb 9, 2024
Merged
@cachemeifyoucan
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#8165

@swift-ci please smoke test

artemcm
artemcm reviewed Feb 9, 2024
View reviewed changes
@cachemeifyoucan
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#8165

@swift-ci please smoke test

@cachemeifyoucan
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#8165

@swift-ci please smoke test

@cachemeifyoucan
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#8165

@swift-ci please smoke test macOS platform

1 similar comment
@cachemeifyoucan
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#8165

@swift-ci please smoke test macOS platform

@cachemeifyoucan
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#8165

@swift-ci please smoke test

@cachemeifyoucan
[Caching][NFC] Restructure CASOption in swift. NFC
3986937 
Clean up how CASOptions are kept and passed inside swift to make the
code more readable. Also avoid a copy of CAS configuration in
ClangImporter.
@cachemeifyoucan
[Caching] Use subInvocation to verify interface
ebc90ff 
The interface verification needs to read some command-line from the
interface file so it needs to be built inside sub-invocation.

rdar://122423965
@cachemeifyoucan
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#8165

@swift-ci please smoke test

@cachemeifyoucan
Copy link
Contributor Author

ping

artemcm
artemcm approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@cachemeifyoucan cachemeifyoucan merged commit 9607e9d into swiftlang:main Feb 13, 2024
@cachemeifyoucan cachemeifyoucan deleted the eng/PR-122423965 branch February 13, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@akyrtzi akyrtzi Awaiting requested review from akyrtzi

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

@ahoppen ahoppen Awaiting requested review from ahoppen

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@hyp hyp Awaiting requested review from hyp

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cachemeifyoucan @artemcm