Skip to content

SwiftExpressionParser: link swiftrt to liblldb on linux #8244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

eeckstein
Copy link

This is need to let the swiftCompilerModules work properly.

Fixes the linux PR test failures for swiftlang/swift#71723

This is need to let the swiftCompilerModules work properly.
@eeckstein eeckstein requested a review from etcwilde February 21, 2024 09:52
@eeckstein
Copy link
Author

@swift-ci test

Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a build log/build.ninja for this? The change itself looks fine, but CMake should be using Swift as the linker here, which should be linking swiftrt.o/swiftrt.obj automatically when appropriate so this shouldn't be necessary.

@atrick
Copy link

atrick commented Feb 21, 2024

@etcwilde I reran linux tests here:
swiftlang/swift#71723

Presumably that will give you a build log if you grab it in time. @eeckstein may have one locally.

@eeckstein
Copy link
Author

eeckstein commented Feb 21, 2024

I tested this locally. CMake doesn't use swiftc for linking. It's using clang++

@eeckstein eeckstein merged commit c84491a into swiftlang:stable/20230725 Feb 22, 2024
@eeckstein eeckstein deleted the add-swiftrt branch February 22, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants