SwiftCompilerSources: refactor and verify conformances to ForwardingInstruction #71723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eeckstein
commented
Feb 19, 2024
eeckstein
commented
- add the ability to implement SIL verification in swift
- add all missing instruction classes and require that all new instructions must be added and registered in SwiftCompilerSources as well
- add ForwardingInstruction conformances to missing forwarding instruction classes
- move all the forwarding instruction conformance definitions into ForwardingInstructions.swift
|
@swift-ci test |
eeckstein
force-pushed
the
swift-verifier
branch
from
054959b to
fa68759
Compare
|
@swift-ci test |
eeckstein
force-pushed
the
swift-verifier
branch
from
fa68759 to
6dfc947
Compare
|
@swift-ci test |
atrick
approved these changes
Feb 19, 2024
|
Note that I had made some of the same fixes here: So I rebased on top of this PR and am now waiting for it to be merged first. |
|
@swift-ci test linux platform |
|
Rerunning linux tests since the old build log is no longer available. |
It's not needed because UnaryInstruction is "derived" from Instruction which has this property.
And require that all new instructions must be added and registered in SwiftCompilerSources as well.
Because it can only appear in the initializer list of a global variable.
* add ForwardingInstruction conformances to missing forwarding instruction classes * move all the forwarding instruction conformance definitions into ForwardingInstructions.swift * remove the default implementations of the requirements, so that every instruction needs to specify them
Verify that the C++ view of forwarding instructions agrees with the swift ForwardInstruction conformances.
eeckstein
force-pushed
the
swift-verifier
branch
from
6dfc947 to
a13a6e0
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.