[clang][ScanDeps] Canonicalize -D and -U flags #8251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
jansvoboda11
approved these changes
Feb 22, 2024
jansvoboda11
approved these changes
Feb 22, 2024
Bigcheese
force-pushed
the
dev/canonicalize-macros-stable-20230725
branch
from
935ec22 to
9a0c91f
Compare
|
@swift-ci test Previous version had test issues on Windows, should be fixed now. |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci test llvm |
|
@swift-ci test linux platform |
Bigcheese
force-pushed
the
dev/canonicalize-macros-stable-20230725
branch
from
9a0c91f to
9474cf8
Compare
|
Tests all failed because of unrelated issues. Rebased and trying again. |
|
@swift-ci test |
|
@swift-ci test llvm |
|
@swift-ci test windows platform |
Canonicalize `-D` and `-U` flags by sorting them and only keeping the last instance of a given name. This optimization will only fire if all `-D` and `-U` flags start with a simple identifier that we can guarantee a simple analysis of can determine if two flags refer to the same identifier or not. See the comment on `getSimpleMacroName()` for details of what the issues are. Cherry pick of: llvm#82568
Bigcheese
force-pushed
the
dev/canonicalize-macros-stable-20230725
branch
from
9474cf8 to
70bda48
Compare
|
@swift-ci test |
|
@swift-ci test llvm |
|
@swift-ci test windows platform |
1 similar comment
|
@swift-ci test windows platform |
|
LLVM Linux test failures are unrelated and already existing. |
|
I'm told the failing Windows test is flakey, retesting. |
|
@swift-ci test windows platform |
1 similar comment
|
@swift-ci test windows platform |
|
swiftlang/swift#71886 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canonicalize
-Dand-Uflags by sorting them and only keeping the last instance of a given name.This optimization will only fire if all
-Dand-Uflags start with a simple identifier that we can guarantee a simple analysis of can determine if two flags refer to the same identifier or not. See the comment ongetSimpleMacroName()for details of what the issues are.Cherry pick of: llvm#82568