Skip to content

Temporarily disable 'edited_method_body.swift' and 'edited_property_getter.swift' while investigating CI failures #71886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Feb 26, 2024

No description provided.

…etter.swift' while investigating CI failures
@artemcm
Copy link
Contributor Author

artemcm commented Feb 26, 2024

@swift-ci smoke test

@shahmishal
Copy link
Member

cc: @compnerd

@shahmishal shahmishal disabled auto-merge February 26, 2024 18:14
@shahmishal shahmishal merged commit 7b5502b into swiftlang:main Feb 26, 2024
@artemcm
Copy link
Contributor Author

artemcm commented Feb 26, 2024

Module remarks do yield some more info.

<unknown>:0: remark: loaded module '_Concurrency'; source: 't:\1\lib\swift\windows\_Concurrency.swiftmodule\x86_64-unknown-windows-msvc.private.swiftinterface', loaded:
't:\1\lib\swift\windows\_Concurrency.swiftmodule\x86_64-unknown-windows-msvc.swiftmodule'

happens on the first of the two compiles, and then on the second one we get:

<unknown>:0: remark: loaded module '_Concurrency'; source: 't:\1\lib\swift\windows\_Concurrency.swiftmodule\x86_64-unknown-windows-msvc.private.swiftinterface', loaded:
'T:\1\swift-test-results\x86_64-unknown-windows-msvc\clang-module-cache\_Concurrency-1JY50GAN4EIFO.swiftmodule'

I wonder if the timing works out such that some other process/test builds a module into the module cache between these two runs, and, for some reason, we then decide to not use the pre-built adjacent binary module, in favour of the module-cache one.

@artemcm artemcm deleted the TemporaryDisableInterfaceHashWindows branch March 28, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants