[lldb] Support frame variable for generic types in embedded Swift #8267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support finding generic types when debugging embedded Swift by following the DW_AT_linkage_name attribute emitted by the compiler that connects the substituted generic type back to the non-substituted one.
| @@ -129,3 +129,61 @@ def test(self): | |||
| "subSubField = (field = 4.2000000000000002)", | |||
| ], | |||
| ) | |||
|
|
|||
| self.expect( | |||
There was a problem hiding this comment.
It would be more stable to use lldbutil.check_variable here.
There was a problem hiding this comment.
check_variable doesn't allow for checking for substrings, which I need in most of these tests
There was a problem hiding this comment.
What I meant was to write this as a chain of
var = frame.FindVariable("foo")
child = var.GetChildAtIndex(0)
lldbutil.check_var(child, ...)
So each check is precise and not depending on the formatting of the aggregate type.
There was a problem hiding this comment.
Ok, I'll do that in an NFC patch, as that file has a lot of checks and will take a while to convert them all
lldb/test/API/lang/swift/embedded/frame_variable/TestSwiftEmbeddedFrameVariable.py
Show resolved
Hide resolved
1 similar comment
|
@swift-ci test Windows |
|
@swift-ci test macOS |
kastiglione
reviewed
Feb 29, 2024
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserSwiftDescriptorFinder.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserSwiftDescriptorFinder.cpp
Outdated
Show resolved
Hide resolved
augusto2112
force-pushed
the
gen-types-dwarf
branch
from
38edc34 to
75a08e3
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support finding generic types when debugging embedded Swift by following the DW_AT_linkage_name attribute emitted by the compiler that connects the substituted generic type back to the non-substituted one.