Skip to content

[cherry-pick] [lldb] Support frame variable for generic types in embedded Swift #8445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2024
Merged

[cherry-pick] [lldb] Support frame variable for generic types in embedded Swift #8445

merged 3 commits into from
Mar 21, 2024

Conversation

augusto2112
Copy link 

[lldb] Change embedded swift test to use "clean" doubles

(cherry picked from commit 75a08e36298018cb6cddcca92f9faf26679d0394)

@augusto2112
[lldb] Support frame variable for generic types in embedded Swift
147dfb4 
Support finding generic types when debugging embedded Swift by following
the DW_AT_linkage_name attribute emitted by the compiler that connects
the substituted generic type back to the non-substituted one.

(cherry picked from commit 257d460)
@augusto2112
[lldb] Change embedded swift test to use "clean" doubles
1d1c20d 
(cherry picked from commit 75a08e3)
@augusto2112
Copy link
Author

@swift-ci test

@augusto2112
Copy link
Author

Original PR: #8267

@augusto2112
Copy link
Author

@swift-ci test

@augusto2112
Copy link
Author

@swift-ci smoke test

@augusto2112
Copy link
Author

@swift-ci test windows

@augusto2112
Copy link
Author

@adrian-prantl I added the nfc commit you asked to change the test to use check_variable here

adrian-prantl
adrian-prantl approved these changes Mar 21, 2024
View reviewed changes
Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@augusto2112
Copy link
Author

@swift-ci test Windows

@adrian-prantl adrian-prantl merged commit 7407910 into swiftlang:swift/release/6.0 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-prantl adrian-prantl adrian-prantl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@augusto2112 @adrian-prantl