Surface errors in GetNumChildren. #8376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the end this value comes from TypeSystem::GetNumChildren which returns a uint32_t, so ValueObject should be consistent with that. (cherry picked from commit 54c955b)
…int32_t This way it is consistent with ValueObject and TypeSystem. (cherry picked from commit 3d7c5b8)
(cherry picked from commit e710523)
(cherry picked from commit 7fc583c)
…xpected (llvm#84219) Change GetNumChildren()/CalculateNumChildren() methods return llvm::Expected This is an NFC change that does not yet add any error handling or change any code to return any errors. This is the second big change in the patch series started with llvm#83501 A follow-up PR will wire up error handling. (cherry picked from commit 624ea68)
This is a proof-of-concept patch that illustrates how to use the Expected return values to surface rich error messages all the way up to the ValueObjectPrinter. This is the final patch in the series that includes llvm#83501 and llvm#84219 (cherry picked from commit 6462ead)
|
@swift-ci test |
This patch will allow displaying unresolved types in composite types
as errors instead of "{}" empty types.
rdar://123794838
adrian-prantl
force-pushed
the
123794838
branch
from
f248fe5 to
1ab3de7
Compare
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
drodriguez
reviewed
Mar 13, 2024
| "TypeSystemSwiftTypeRef diverges from SwiftASTContext"); \ | ||
| return IMPL(); \ | ||
| } while (0) | ||
|
|
||
| #else | ||
| #define VALIDATE_AND_RETURN_STATIC(IMPL, REFERENCE) \ | ||
| FALLBACK(REFERENCE, ()); \ |
There was a problem hiding this comment.
This FALLBACK(REFERENCE, ()) has not been modified for the third parameter.
Also the one in line 2229 which I cannot leave a comment in.
One also need VALIDATE_AND_RETURN_EXPECTED equivalent in that #else branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will allow displaying unresolved types in composite types
as errors instead of "{}" empty types.
rdar://123794838