Skip to content

Fix compile errors in no-asserts configuration #8394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

adrian-prantl
Copy link

Thanks @drodriguez for pointing this out!

@adrian-prantl
Copy link
Author

@swift-ci test

@drodriguez
Copy link

@swift-ci please test llvm

@adrian-prantl
Copy link
Author

@swift-ci test llvm

@drodriguez
Copy link

I left comments about those LLVM test failures in #8253 and #8254.

@drodriguez
Copy link

@swift-ci please test Windows platform

@al45tair
Copy link

al45tair commented Mar 14, 2024

FYI, I'm reverting #8254 (the revert is #8396), and #8397 should fix the problem #8253 introduced.

@adrian-prantl
Copy link
Author

@swift-ci test windows

6 similar comments
@adrian-prantl
Copy link
Author

@swift-ci test windows

@adrian-prantl
Copy link
Author

@swift-ci test windows

@adrian-prantl
Copy link
Author

@swift-ci test windows

@adrian-prantl
Copy link
Author

@swift-ci test windows

@adrian-prantl
Copy link
Author

@swift-ci test windows

@adrian-prantl
Copy link
Author

@swift-ci test windows

@al45tair
Copy link

al45tair commented Mar 14, 2024

Hmmm. I wonder if the not-triggering-Windows thing is related to the 403 errors I'm getting from ci-external.swift.org right now?

@adrian-prantl
Copy link
Author

@swift-ci test windows

1 similar comment
@adrian-prantl
Copy link
Author

@swift-ci test windows

@adrian-prantl
Copy link
Author

@swift-ci test windows

@adrian-prantl adrian-prantl merged commit 097616a into swiftlang:stable/20230725 Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants