Skip to content

[cas] Add cc1 option -finclude-tree-preserve-pch-path #8570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

benlangmuir
Copy link

Add the PCH path to the include tree, and add a way to control whether we use the original PCH path, or if we canonicalize it away to . For now, keep the default being to canonicalize it to as this improves canonicalization. However, a client (e.g. Swift) that knows its PCH path will be stable can use this option to allow enabling -gmodules, which requires a real path.

rdar://126370706

Add the PCH path to the include tree, and add a way to control whether
we use the original PCH path, or if we canonicalize it away to <PCH>.
For now, keep the default being to canonicalize it to <PCH> as this
improves canonicalization. However, a client (e.g. Swift) that knows its
PCH path will be stable can use this option to allow enabling -gmodules,
which requires a real path.

rdar://126370706
@benlangmuir
Copy link
Author

@swift-ci please test llvm

@benlangmuir
Copy link
Author

@swift-ci please test

@benlangmuir
Copy link
Author

@swift-ci please test Windows

Copy link

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think PCM built from swift can have PCH files but I am fine with using a more general cases to cover swift usage.

@benlangmuir benlangmuir merged commit a28c877 into stable/20230725 Apr 15, 2024
@benlangmuir benlangmuir deleted the eng/blanmuir/finclude-tree-preserve-pch-path-stable branch April 15, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants