[cas] Add cc1 option -finclude-tree-preserve-pch-path #8575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the PCH path to the include tree, and add a way to control whether we use the original PCH path, or if we canonicalize it away to <PCH>. For now, keep the default being to canonicalize it to <PCH> as this improves canonicalization. However, a client (e.g. Swift) that knows its PCH path will be stable can use this option to allow enabling -gmodules, which requires a real path. rdar://126370706 (cherry picked from commit 67dab5f)
|
@swift-ci please test |
fredriss
approved these changes
Apr 16, 2024
benlangmuir
deleted the
eng/blangmuir/finclude-tree-preserve-pch-path-6.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-gmodulesdue to concerns about stability of the PCH path. This change adds a new option to opt-in to using the PCH path as-is, which can be used by Swift since Swift PCH paths do not have this concern. With this option set, we then allow-gmodules, which fixes debugging Swift code, which is the motivation behind this change -- see [Caching] Adopt -finclude-tree-preserve-pch-path to fix -gmodules with swift#73038