[6.0 🍒][clang][deps] Collect discovered module dependencies' Link Libraries #8809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test Windows platform |
This will allow scanner clients to be able to compute e.g. auto-linking dependencies of the scanned translation unit.
artemcm
force-pushed
the
Swift60_ExplicitAutoLinkScanner
branch
from
19bb623 to
0dd4a0f
Compare
|
@swift-ci test |
nkcsgexi
approved these changes
Jun 4, 2024
|
ah, thank you for updating them, @NuriAmari ! |
@nkcsgexi No problem, but I can't merge or run tests myself, nor am I sure which branches to merge into. If someone could take a look at the PR, that'd be great. Thanks. |
NuriAmari
pushed a commit
to NuriAmari/llvm-project
that referenced
this pull request
Jun 5, 2024
Tests `test/ClangScanDeps/modules-cas-full-by-mod-name.c`, and `test/ClangScanDeps/modules-include-tree-by-mod-name.c` were broken by swiftlang#8809. These tests needed adjusting to account for the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of llvm#93588
Explanation: This will allow scanner clients to be able to compute e.g. auto-linking dependencies of the scanned translation unit.
Risk: Low. This change is additive and does not exercise meaningfully-changed code-paths.
Testing: Automated test added to the compiler test suite.
Reviewed By: @benlangmuir