Skip to content

[clang][deps] Fix ClangScanDeps tests #8856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NuriAmari
Copy link

Tests test/ClangScanDeps/modules-cas-full-by-mod-name.c, and test/ClangScanDeps/modules-include-tree-by-mod-name.c were broken by #8809. These tests needed adjusting to account for the changes.

@NuriAmari
Copy link
Author

I don't entirely understand the branching model, not sure if this will be picked into different stable branches automatically. Needs picking into swift/release/6.0 in any case.

@artemcm
Copy link

artemcm commented Jun 5, 2024

I don't entirely understand the branching model, not sure if this will be picked into different stable branches automatically. Needs picking into swift/release/6.0 in any case.

swift/release/6.0 auto-merges into stable/20230725. Could you please re-target this PR for swift/release/6.0?

Thank you so much for fixing these!

Tests `test/ClangScanDeps/modules-cas-full-by-mod-name.c`, and `test/ClangScanDeps/modules-include-tree-by-mod-name.c`
were broken by swiftlang#8809. These
tests needed adjusting to account for the changes.
@NuriAmari NuriAmari force-pushed the clang-deps-tests-fix branch from dfdc481 to bad2cc3 Compare June 5, 2024 22:56
@NuriAmari NuriAmari changed the base branch from stable/20230725 to swift/release/6.0 June 5, 2024 22:57
@NuriAmari
Copy link
Author

Could you please re-target this PR for swift/release/6.0?

Done

@NuriAmari
Copy link
Author

@swift-ci please smoke test

1 similar comment
@drodriguez
Copy link

@swift-ci please smoke test

@drodriguez
Copy link

@swift-ci please test macOS platform

@drodriguez
Copy link

@swift-ci please test Linux platform

@artemcm artemcm requested a review from nkcsgexi June 6, 2024 16:03
@nkcsgexi nkcsgexi merged commit f95d28a into swiftlang:swift/release/6.0 Jun 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants