Rewrite MachOCASWriter to be a derived class of MachObjectWriter #9086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A significant amount of changes were made upstream to MCAssembler and MachObjectWriter that broke MCCAS. To fix them, we moved a bunch of code from MachObjectWriter to MCObjectWriter as a band-aid fix, but those are full of layering violations, this patch reverts those changes in favor of a correct fix in the next commit which involves rewriting MachOCASWriter to be a derived class if MachObjectWriter.
|
@swift-ci please test llvm |
|
Can you check if the CAS-backend verify mode is still working? I have the vague memory that I have to make sure I have basically two separate ObjectWriter instances to make it working but I could be wrong. |
I tried to check the verify flag by building a clang with `env CCC_OVERRIDE_OPTIONS=+-Xclang +-fcas-backend +-Xclang +-fcas-path +-Xclang +/tmp/cas +-fcas-backend-mode=verify' and it worked |
rastogishubham
force-pushed
the
MachOCASWriterRewrite
branch
from
0f3ea61 to
849db0f
Compare
rastogishubham
force-pushed
the
MachOCASWriterRewrite
branch
from
849db0f to
0259ef4
Compare
This patch rewrites MachOCASWriter to be a derived class of MachObjectWriter which fixes a lot of the issues we see from the changes made to MCAssembler. This also fixes the issue of the MCMachoStreamer only having calls to the getWriter() function that returns a MachOCASWriter.
rastogishubham
force-pushed
the
MachOCASWriterRewrite
branch
from
0259ef4 to
895cd5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch rewrites MachOCASWriter to be a derived class of MachObjectWriter which fixes a lot of the issues we see from the changes made to MCAssembler. This also fixes the issue of the MCMachoStreamer only having calls to the getWriter() function that returns a MachOCASWriter.
It also reverts all the changes made to MCObjectWriter for rdar://133264719 and rdar://133001453