Rewrite MachOCASWriter to be a derived class of MachObjectWriter #9111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A significant amount of changes were made upstream to MCAssembler and MachObjectWriter that broke MCCAS. To fix them, we moved a bunch of code from MachObjectWriter to MCObjectWriter as a band-aid fix, but those are full of layering violations, this patch reverts those changes in favor of a correct fix in the next commit which involves rewriting MachOCASWriter to be a derived class if MachObjectWriter. (cherry picked from commit 91e9561)
|
@swift-ci please test |
|
@swift-ci please test llvm |
rastogishubham
force-pushed
the
MachOCASWriterRewriteStable
branch
from
cc01163 to
49eed84
Compare
|
@swift-ci please test |
|
@swift-ci please test llvm |
This patch rewrites MachOCASWriter to be a derived class of MachObjectWriter which fixes a lot of the issues we see from the changes made to MCAssembler. This also fixes the issue of the MCMachoStreamer only having calls to the getWriter() function that returns a MachOCASWriter. (cherry picked from commit 895cd5a)
rastogishubham
force-pushed
the
MachOCASWriterRewriteStable
branch
from
49eed84 to
61aec53
Compare
|
@swift-ci please test |
|
@swift-ci please test llvm |
|
@swift-ci please test |
|
@swift-ci please test llvm |
|
The Linux build failed the following test: |
|
@swift-ci please test Windows platform |
|
@compnerd the linux platform test break is not because of this patch, look at |
|
@rastogishubham yeah, I agree. The Windows build hung but got further than without the change. I think that this is fine to merge personally. |
|
The windows build is failing on swift-driver, far after the LLVM build, I think that this is ready to merge. |
rastogishubham
merged commit 8f9beda
into
swiftlang:stable/20240723
0 of 5 checks passed
|
@compnerd thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch rewrites MachOCASWriter to be a derived class of MachObjectWriter which fixes a lot of the issues we see from the changes made to MCAssembler. This also fixes the issue of the MCMachoStreamer only having calls to the getWriter() function that returns a MachOCASWriter.
It also reverts all the changes made to MCObjectWriter for rdar://133264719 and rdar://133001453
(It is a cherry-pick of PR: #9086)