forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 341
[DebugInfo] Remove spare bits mask from LLVM IR and DWARF #9425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
augusto2112
merged 2 commits into
swiftlang:stable/20240723
from
augusto2112:remove-spare-bits-debug
Oct 17, 2024
Merged
[DebugInfo] Remove spare bits mask from LLVM IR and DWARF #9425
augusto2112
merged 2 commits into
swiftlang:stable/20240723
from
augusto2112:remove-spare-bits-debug
Oct 17, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci test |
f97112c
to
1f6330e
Compare
@swift-ci test |
We are able to calculate the spare bits mask from other information. Remove this from the LLVM IR representation and DWARF.
1f6330e
to
74d4671
Compare
RemoteMirrors is able to calculate type infos for multipaylaod enums without needing MultiPayloadEnumDescriptors. Remove the implementation that provides those descriptors from LLDB.
adrian-prantl
approved these changes
Oct 16, 2024
felipepiovezan
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with this customization, but glad to see such an invasive change be removed from downstream!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are able to calculate the spare bits mask from other information. Remove this from the LLVM IR representation and DWARF.