Skip to content

[DebugInfo] Remove spare bits mask from LLVM IR and DWARF #9425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

augusto2112
Copy link

@augusto2112 augusto2112 commented Oct 15, 2024

We are able to calculate the spare bits mask from other information. Remove this from the LLVM IR representation and DWARF.

@augusto2112
Copy link
Author

@swift-ci test

@augusto2112
Copy link
Author

@swift-ci test

@augusto2112
Copy link
Author

swiftlang/swift#77038
@swift-ci test

We are able to calculate the spare bits mask from other information.
Remove this from the LLVM  IR representation and DWARF.
@augusto2112 augusto2112 force-pushed the remove-spare-bits-debug branch from 1f6330e to 74d4671 Compare October 15, 2024 23:30
@augusto2112
Copy link
Author

swiftlang/swift#77038
@swift-ci test

RemoteMirrors is able to calculate type infos for multipaylaod enums
without needing MultiPayloadEnumDescriptors. Remove the implementation
that provides those descriptors from LLDB.
@augusto2112
Copy link
Author

swiftlang/swift#77038
@swift-ci test

@augusto2112
Copy link
Author

swiftlang/swift#77038
@swift-ci test

Copy link

@felipepiovezan felipepiovezan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with this customization, but glad to see such an invasive change be removed from downstream!

@augusto2112 augusto2112 merged commit d17f9d8 into swiftlang:stable/20240723 Oct 17, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants