[DebugInfo] Stop emitting spare bits mask in debug info #77038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're now able to calculate the spare bits mask from other information. Stop emitting it in debug info.
without relying on spare bit information in the reflection metadata (which was added in swiftlang#40906). As a result, we can remove the code from swiftlang#40906. This is the first step in such removal. It removes the RemoteMirror code for looking up such metadata. It leaves behind: * Sufficient stubs for LLDB to continue to build. Once LLDB is updated, these stubs can be removed as well. * The compiler code to emit such metadata. This allows new binaries to still reflect MPEs on older runtimes. This will need to be kept for a transitional period. (cherry picked from commit c20ef6d)
augusto2112
requested review from
mikeash,
al45tair,
slavapestov and
a team
as code owners
|
I'll defer to @tbkka to accept this. |
Remote Mirrors is able to calculate type infos without needing MultiPayloadEnumDescriptors. Remove the functionality to look it up.
augusto2112
force-pushed
the
stop-spare-bits-debug
branch
from
f628bac to
6b704ad
Compare
tbkka
approved these changes
Oct 16, 2024
al45tair
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now able to calculate the spare bits mask from other information. Stop emitting it in debug info.