Skip to content

[cherry-pick][debugserver] Mark ASAN memory regions as "heap" #9475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

felipepiovezan
Copy link

This memory type is currently not handled, but it makes sense to mark it as a heap allocation in requests asking for memory region info.

Copy link

@jasonmolenda jasonmolenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this should be landed upstream shouldn't it?

@felipepiovezan
Copy link
Author

LGTM but this should be landed upstream shouldn't it?

Oh yeah, good point.

This memory type is currently not handled, but it makes sense to mark it
as a heap allocation in requests asking for memory region info.

(cherry picked from commit 474234a)
@felipepiovezan felipepiovezan force-pushed the felipe/implement_asan_memory_type branch from 7d3cfe5 to 589fe1c Compare October 28, 2024 22:03
@felipepiovezan
Copy link
Author

Transformed this into a cherry-pick of the patch landed upstream.

@felipepiovezan
Copy link
Author

@swift-ci test

@felipepiovezan felipepiovezan changed the title [debugserver] Mark ASAN memory regions as "heap" [cherry-pick][debugserver] Mark ASAN memory regions as "heap" Oct 28, 2024
@felipepiovezan felipepiovezan merged commit 417d34b into swiftlang:stable/20240723 Oct 29, 2024
2 checks passed
@felipepiovezan felipepiovezan deleted the felipe/implement_asan_memory_type branch October 29, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants